Repository navigation
Move CI to Python 3.11, with the version set in .python-version - #49311
Merged
Merged
Conversation
- `.python-version` is the single source of the CI Python version. - GitHub Actions workflows use `python-version-file: .python-version`. - The CPU CI images now build on a shared `docker/ci-base.dockerfile` via `docker/docker-bake.hcl`; the build workflows pass `PYTHON_VERSION` from `.python-version`. Same for the doc-builder image. - consistency image: `pypi-kenlm` doesn't build on 3.11, use `kenlm` (needs cmake). - `check_circleci_user` only runs shell, use `cimg/base:stable`.
tarekziade
commented
Oct 5, 2026
| @@ -0,0 +1 @@ | |||
| 3.11 | |||
Collaborator
Author
There was a problem hiding this comment.
@ydshieh Adding this file, that should have minimal impact for developers, but if you want we can move it to docker/
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ydshieh
approved these changes
Oct 5, 2026
| # Ensure running with CircleCI/huggingface | ||
| check_circleci_user: | ||
| docker: | ||
| - image: python:3.10-slim |
Collaborator
There was a problem hiding this comment.
let's not bother to touch this. circleci is not used anymore.
Collaborator
Author
There was a problem hiding this comment.
even for branch releases? also, if not used anymore should we delete it?
tarekziade
added a commit
that referenced
this pull request
Oct 5, 2026
This was referenced Oct 5, 2026
tarekziade
enabled auto-merge
October 6, 2026 09:44
Contributor
CI recapDashboard: View test results in Grafana |
ydshieh
added a commit
that referenced
this pull request
Oct 20, 2026
) Add /opt/venv/bin to PATH in SSH runner env setup New GPU docker images (Python 3.11 migration, PR #49311) install packages into a uv-managed venv at /opt/venv, with PATH set via Dockerfile ENV. CI jobs inherit this correctly, but interactive SSH sessions start a fresh shell that doesn't source Docker ENV vars, so python3/pip/pytest are not found. Safe for all images: prepending a non-existent directory to PATH is a no-op. Co-authored-by: ydshieh <ydshieh@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
.python-versionis the single source of the CI Python version.python-version-file: .python-version.docker/ci-base.dockerfileviadocker/docker-bake.hcl; the build workflows passPYTHON_VERSIONfrom.python-version. Same for the doc-builder image.pypi-kenlmdoesn't build on 3.11, usekenlm(needs cmake).check_circleci_useronly runs shell, usecimg/base:stable.