Repository navigation
[Distributed] Set device_id only for NCCL - #50281
Merged
3outeille merged 2 commits intoNov 3, 2026
Merged
Conversation
cdbhatia-aws
approved these changes
Nov 2, 2026
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Nov 3, 2026
3outeille
approved these changes
Nov 3, 2026
vasqu
pushed a commit
that referenced
this pull request
Nov 6, 2026
fix: set device_id only for nccl Co-authored-by: Ferdinand Mom <47445085+3outeille@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Issue
_ensure_torch_distributedsetsdevice_idfor every backend except CPUs. This allows to initialize a process group and tell it right away which device is associated to the current rank. It provides several benefits afterwards.The issue is that when the
DeviceMeshis built, it sees abound_device_idand builds its subgroups withsplit_groups, which is not supported by all backends. For example Trainium does not support it:Fix
We pass
device_idonly for the NCCL backend. Other supported backends can be added later on.