Repository navigation
fix: upload minutes, agenda, bluesheets fail if UTF-8 check fails - #11965
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11965 +/- ##
=======================================
Coverage 89.04% 89.05%
=======================================
Files 342 342
Lines 46590 46631 +41
=======================================
+ Hits 41488 41529 +41
Misses 5102 5102 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jennifer-richards
approved these changes
Oct 28, 2026
1 task done
rpcross
added a commit
to rpcross/datatracker
that referenced
this pull request
Oct 28, 2026
Carry the require_field fix from ietf-tools#11965 into UploadOrEnterFormMixin, which replaced the UploadOrEnterAgendaForm it was made in, so a failed UTF-8 check no longer also reports "You must fill in this field". Initialize file_encoding in FileUploadForm and record UTF-8 for entered text, so the agenda and bluesheet views read the encoding the same way. Claude-Session: https://claude.ai/code/session_01VCvCDMsamhx8uxq4JC2Eyt
jennifer-richards
pushed a commit
that referenced
this pull request
Oct 29, 2026
* fix: accept text/csv bluesheet uploads Bluesheet .txt files with comma-separated attendee lines are sniffed by libmagic as text/csv and were rejected as an unexpected mime type. Allow text/csv for bluesheets and accept it when the browser uploads the file as text/plain. Relates to #7804 * feat: allow entering bluesheet text directly Add an Upload/Enter choice to the bluesheet upload page, like the one on the agenda page. Entered text is saved as a .txt revision. When revising a .txt bluesheet, the text box starts with the current text. Move the upload-or-enter form logic into a shared mixin used by both the agenda and bluesheet forms. Rename upload-session-agenda.js to upload-or-enter-material.js, since both pages now use it. Relates to #7804 * fix: replace jquery with vanilla js * fix: include text/csv as valid * fix: integrate UTF-8 upload validation with upload-or-enter forms Carry the require_field fix from #11965 into UploadOrEnterFormMixin, which replaced the UploadOrEnterAgendaForm it was made in, so a failed UTF-8 check no longer also reports "You must fill in this field". Initialize file_encoding in FileUploadForm and record UTF-8 for entered text, so the agenda and bluesheet views read the encoding the same way. Claude-Session: https://claude.ai/code/session_01VCvCDMsamhx8uxq4JC2Eyt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.