Repository navigation
chore(mobile): make openapi requests abortable - #28692
Conversation
|
📱 Android release APK (universal) — Download: https://github.com/immich-app/immich/actions/runs/26663274030/artifacts/7301651247 QR codeInstalls as a separate app (applicationId |
jrasm91
left a comment
jrasm91
left a comment
There was a problem hiding this comment.
This seems like something to PR upstream
|
We can, but that'll take some time to land and get in a release. This affects background task reliability, so I don't think we need to wait on that in the meantime. |
I contributed upstream a bit, so the maintainer knows be by now, which usually helps getting things merged faster. I can send the patch over there. Meanwhile merging this PR |
make open-api requests abortable
…PITools/openapi-generator#23930) partially revert "chore(mobile): make openapi requests abortable (#28692)"
…PITools/openapi-generator#23930) partially revert "chore(mobile): make openapi requests abortable (#28692)"
* remove patch in favor of [OpenAPITools/openapi-generator#23930](OpenAPITools/openapi-generator#23930) partially revert "chore(mobile): make openapi requests abortable (#28692)" * gen client * bump openapi-generator version to v7.24.0 * gen client * enum migration changes * drop enum exhaustion switch check
Description
This PR allows using the standard
http.Clientmechanism to abort requests, which is useful for both teardown and overall responsiveness.