Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

Reduce de complexity of the js-ipfs-api module - #313

Merged
daviddias merged 4 commits into
ipfs-api/ngfrom
clean-madness
Aug 15, 2016
Merged

daviddias merged 4 commits into
ipfs-api/ngfrom
clean-madness

Conversation

@daviddias

@daviddias daviddias commented Jul 2, 2016 •

Copy link
Copy Markdown
Contributor

WIP

Right now, the guts of js-ipfs-api are overly complex, making it hard to debug, to apply changes or even to develop, since we have to run every single test every single time. To make the experience more pleasant, this PR has the goals to:

What other things would you like to see that would make using the js-ipfs-code more sane?

Comment thread src/request-api.js

const opts = {
method: files ? 'POST' : 'GET',
method: 'POST',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all requests should be POST requests

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's check with @whyrusleeping, I've changed this after a conversation with him when we were debugging some npm-on-ipfs stuff.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ›Ž

individually and reduce complexity inside ipfs-api
@daviddias

Copy link
Copy Markdown
Contributor Author

@victorbjelkholm moving away from the argument flags :) #43a1dfa

@daviddias
daviddias force-pushed the clean-madness branch 2 times, most recently from cf157bc to c6aef50 Compare August 15, 2016 01:26
@daviddias

Copy link
Copy Markdown
Contributor Author

I've refactored all the test units that not require multiple nodes, to be come isolated. Will handle the remaining (3) with the interface-ipfs-core tests.

@daviddias
daviddias merged commit 776cccd into ipfs-api/ng Aug 15, 2016
@daviddias
daviddias deleted the clean-madness branch August 15, 2016 01:37
@dignifiedquire

Copy link
Copy Markdown
Contributor

Why u no wait for CR?

@daviddias

daviddias commented Aug 15, 2016 •

Copy link
Copy Markdown
Contributor Author

It was not merged to master, it was merged to the other PR branch ;)
Apply CR here: #305

@dignifiedquire

Copy link
Copy Markdown
Contributor

ahh okay :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants