Skip to content

Improve support for IPNS double-hashed entries - #41

Merged
hsanjuan merged 7 commits into
masterfrom
fix/40-ipns-double-hashed
Dec 13, 2024
Merged

hsanjuan merged 7 commits into
masterfrom
fix/40-ipns-double-hashed

Conversation

@hsanjuan

@hsanjuan hsanjuan commented Dec 11, 2024 •

Copy link
Copy Markdown
Collaborator

Fixes #40. This ensures that double-hashed IPNS entries both in modern and legacy forms are correctly supported, including both:

  • /ipns/<domain>
  • /ipns/key

Before, only the modern form with /ipns/ was correctly supported for double-hashed entries.

Testcases have been added for all forms.

The double-hashing check code that was duplicated in several functions has been consolidated.

Fixes #40. This ensures that double-hashed IPNS entries both in modern and legacy
forms are correctly supported, including both:
  * /ipns/<domain>
  * /ipns/key

Before, only the modern form with /ipns/<domain> was correctly supported for
double-hashed entries.

Testcases have been added for all forms.
It was repeated in all check functions
@hsanjuan
hsanjuan requested a review from lidel December 11, 2024 12:59

@lidel lidel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, small cosmetics inline, but feel free to merge + maybe also make a release and PR kubo and rainbow so we don't forget?

Comment thread denylist.go Resolved
Comment thread denylist.go Resolved
Comment thread denylist.go Resolved
Comment thread denylist.go Resolved
hsanjuan and others added 5 commits December 13, 2024 10:37
Co-authored-by: Marcin Rataj <lidel@lidel.org>
Co-authored-by: Marcin Rataj <lidel@lidel.org>
Co-authored-by: Marcin Rataj <lidel@lidel.org>
Co-authored-by: Marcin Rataj <lidel@lidel.org>
@hsanjuan
hsanjuan merged commit db00015 into master Dec 13, 2024
@hsanjuan
hsanjuan deleted the fix/40-ipns-double-hashed branch December 13, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support legacy double-hash entries for IPNS CIDs and DNSLink

2 participants