Skip to content

bitswap: reenable unit testsΒ #327

Closed

Description

@BigLep

Done Criteria

Bitswap has tests reenabled such that we remove judgement from developers. CI must be green before we merge.

Why Important

In the absence of clear signal, developers have sometimes skipping CI checks, which in at least one instance caused a bug to go through.

Notes

This isn't intended to be a "fix the flaky tests" effort. For now we can just rerun the flaky tests X times. We need to get to a place though where all tests have to pass before we merge.

Internal conversation on this: https://filecoinproject.slack.com/archives/C04SWLJ2QQ4/p1684434613517719

Activity

  1. added
    need/triageNeeds initial labeling and prioritization
    and removed
    need/triageNeeds initial labeling and prioritization
    on May 31, 2023
  2. added
    help wantedSeeking public contribution on this issue
    on Jun 2, 2023
  3. Jorropo commented on Jun 2, 2023

    @Jorropo
    Contributor

    What we want to do is going through trying to remove the tests.Flaky call from the bitswap/... tests and see what tests reliably pass and which one do not.

    Some flaky tests will be very hard to fix, it is fine to leave tests.Flaky for them in some individual PRs, even if the target is to remove all usage of tests.Flaky to fix this issue a PR that leave some but increase code coverage is still awesome.

    We can view coverage progress here: https://app.codecov.io/gh/ipfs/boxo/tree/main/bitswap

  4. BigLep commented on Jun 30, 2023

    @BigLep
    ContributorAuthor

    Per sync with PL EngRes Bedrock on 2023-06-30, we'll update with where this sits in the queue (and expected completion date) by 2023-07-07.

  5. moved this to πŸ₯ž Todo in IPFS Shipyard Teamon Jul 6, 2023
  6. BigLep commented on Jul 10, 2023

    @BigLep
    ContributorAuthor

    I signed off on 2023-07-07 without updating this - my bad.
    We expect to complete this this week.
    Before doing this work, @Jorropo is tackling the in-progress fixes for ipfs/kubo#9927 and #209 (comment)

  7. moved this from πŸ₯ž Todo to πŸƒβ€β™€οΈ In Progress in IPFS Shipyard Teamon Aug 3, 2023
  8. BigLep commented on Oct 5, 2023

    @BigLep
    ContributorAuthor

    2023-10-05 conversation:

    • @Jorropo to summarize in this issue what tests are disabled and explain why those tests are disabled. We believe (but need to confirm) that this is all for a particular bug we aren't going to fix currently.
  9. removed their assignment
    on Mar 4, 2024
  10. added a commit that references this issue on Dec 4, 2024
    f8bebb5
  11. added a commit that references this issue on Dec 4, 2024
    e9446bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions