You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Bitswap has tests reenabled such that we remove judgement from developers. CI must be green before we merge.
Why Important
In the absence of clear signal, developers have sometimes skipping CI checks, which in at least one instance caused a bug to go through.
Notes
This isn't intended to be a "fix the flaky tests" effort. For now we can just rerun the flaky tests X times. We need to get to a place though where all tests have to pass before we merge.
What we want to do is going through trying to remove the tests.Flaky call from the bitswap/... tests and see what tests reliably pass and which one do not.
Some flaky tests will be very hard to fix, it is fine to leave tests.Flaky for them in some individual PRs, even if the target is to remove all usage of tests.Flaky to fix this issue a PR that leave some but increase code coverage is still awesome.
I signed off on 2023-07-07 without updating this - my bad.
We expect to complete this this week.
Before doing this work, @Jorropo is tackling the in-progress fixes for ipfs/kubo#9927 and #209 (comment)
@Jorropo to summarize in this issue what tests are disabled and explain why those tests are disabled. We believe (but need to confirm) that this is all for a particular bug we aren't going to fix currently.
Activity
Jorropo commentedon Jun 2, 2023
What we want to do is going through trying to remove the
tests.Flakycall from thebitswap/...tests and see what tests reliably pass and which one do not.Some flaky tests will be very hard to fix, it is fine to leave
tests.Flakyfor them in some individual PRs, even if the target is to remove all usage oftests.Flakyto fix this issue a PR that leave some but increase code coverage is still awesome.We can view coverage progress here: https://app.codecov.io/gh/ipfs/boxo/tree/main/bitswap
BigLep commentedon Jun 30, 2023
Per sync with PL EngRes Bedrock on 2023-06-30, we'll update with where this sits in the queue (and expected completion date) by 2023-07-07.
BigLep commentedon Jul 10, 2023
I signed off on 2023-07-07 without updating this - my bad.
We expect to complete this this week.
Before doing this work, @Jorropo is tackling the in-progress fixes for ipfs/kubo#9927 and #209 (comment)
BigLep commentedon Oct 5, 2023
2023-10-05 conversation:
Reenable flaky bitswap tests
Reenable flaky bitswap tests (#740)