Skip to content

ci: uci/copy-templates - #431

Merged
hacdias merged 10 commits into
mainfrom
uci/copy-templates
Aug 22, 2023
Merged

hacdias merged 10 commits into
mainfrom
uci/copy-templates

Conversation

@web3-bot

Copy link
Copy Markdown
Contributor

This PR was created automatically by the @web3-bot as a part of the Unified CI project.

@web3-bot
web3-bot requested a review from a team as a code owner August 14, 2023 11:28
@codecov

codecov Bot commented Aug 14, 2023 •

Copy link
Copy Markdown

Codecov Report

Merging #431 (413047e) into main (01bd4a0) will increase coverage by 11.39%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #431       +/-   ##
===========================================
+ Coverage   49.75%   61.15%   +11.39%     
===========================================
  Files         249      205       -44     
  Lines       30125    24399     -5726     
===========================================
- Hits        14988    14920       -68     
+ Misses      13690     8030     -5660     
- Partials     1447     1449        +2     
Files Changed Coverage Ξ”
...itswap/testnet/internet_latency_delay_generator.go 85.71% <ΓΈ> (ΓΈ)
examples/unixfs-file-cid/main.go 41.21% <ΓΈ> (ΓΈ)

... and 57 files with indirect coverage changes

@hacdias hacdias mentioned this pull request Aug 15, 2023

@Jorropo Jorropo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ”΄ CI

@Jorropo
Jorropo dismissed their stale review August 15, 2023 12:14

I thought this was the Kubo PR, this is easy to fix once go-libp2p is released.

@web3-bot
web3-bot force-pushed the uci/copy-templates branch from 7777f3f to c2a95c3 Compare August 21, 2023 12:02

@lidel lidel left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green + we've merged #434 which iiuc removes some problems with go1.20.

@Jorropo ok to merge or is go-libp2p bump here a problem?

@Jorropo

Jorropo commented Aug 22, 2023

Copy link
Copy Markdown
Contributor

Assuming the abspath updates are RFM this is ok. cc @hacdias

@hacdias
hacdias enabled auto-merge (squash) August 22, 2023 09:58
@hacdias
hacdias merged commit 9e804b4 into main Aug 22, 2023
@hacdias
hacdias deleted the uci/copy-templates branch August 22, 2023 10:18
hacdias added a commit that referenced this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants