Repository navigation
feat(session): do not record erroneous session want sends - #452
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests β
@@ Coverage Diff @@
## main #452 +/- ##
==========================================
+ Coverage 60.42% 60.44% +0.01%
==========================================
Files 245 245
Lines 31056 31064 +8
==========================================
+ Hits 18766 18777 +11
+ Misses 10621 10616 -5
- Partials 1669 1671 +2
|
Member
|
seems reasonable, aside from probably needing some form of cleanup for cases where the error doesn't ever resolve - we don't want to continue to try this in perpetuity, unless there is already an alternative cleanup mechanism in place for these wants |
Contributor
Author
|
Presumably, the case where the error does not resolve is one where a peer has disconnected, in which case, we will eventually get a disconnected message. |
gammazero
force-pushed
the
feat/do-not-record-what-did-not-happen
branch
from
December 4, 2024 05:31
86a7a45 to
eedee67
Compare
gammazero
force-pushed
the
feat/do-not-record-what-did-not-happen
branch
from
December 4, 2024 05:59
d3e88f1 to
643278e
Compare
gammazero
marked this pull request as ready for review
December 4, 2024 05:59
hsanjuan
approved these changes
Dec 4, 2024
hsanjuan
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Let's try it out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals
Find acceptable fix for #432
Implementation
The basic idea here is there's nothing wrong with the connection event manager -- the problem lies in the fact that the PeerManager never tells the caller it didn't actually send anything cause the peer appeared disconnected. The SessionWantSender in turn updates the state of sent wants based on incorrect assumption something actually happened. This PR deals with the problem by helping the SessionWantSender avoid getting into an incorrect state by not updating its state when SendWants does nothing.
The subsequent connect event should trigger the sending of the WantBlock then.
For discussion
This is just an experiment and a suggestion for someone else to pick up, to help solve #432 more quickly -- I'm not doing the leg work of testing and change log etc