Repository navigation
Remove dependency on goprocess - #710
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #710 +/- ##
==========================================
- Coverage 60.38% 60.35% -0.03%
==========================================
Files 243 243
Lines 31025 31021 -4
==========================================
- Hits 18733 18724 -9
- Misses 10625 10633 +8
+ Partials 1667 1664 -3
|
hsanjuan
approved these changes
Nov 5, 2024
hsanjuan
left a comment
Contributor
There was a problem hiding this comment.
Super happy to see goprocess no more. I believe this is good, I hope I'm not missing something. We should pay attention to goroutine leakage when rolling out RCs in case something is not getting closed as before, but it should be fine.
Contributor
|
Lastest commit LGTM too |
The dependency on goprocess is not needed by boxo, and removing it removes the need to support it in code dependent on boxo. Closes #709
gammazero
force-pushed
the
no-goprocess
branch
from
November 7, 2024 17:38
069d6bf to
19d1d6b
Compare
This was referenced Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dependency on goprocess is not needed by boxo, and removing it removes the need to support it in code dependent on boxo.
Closes #709
Closes #130