Repository navigation
dspinner: RecursiveKeys(): do not hang on cancellations - #727
Merged
Merged
Conversation
Per ipfs/kubo#10593, if no one is reading from the channel returned by RecursiveKeys() and the context is cancelled, streamIndex will hang indefinitely. Proposed fix is to always select when attempting to write to the `out` channel. If the context is done and there is no one to read, we can abort.
hsanjuan
force-pushed
the
fix/kubo-10593
branch
from
November 25, 2024 20:26
2bc8ab8 to
ceec5b7
Compare
3 tasks done
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #727 +/- ##
==========================================
- Coverage 60.35% 60.30% -0.06%
==========================================
Files 244 244
Lines 31029 31034 +5
==========================================
- Hits 18728 18715 -13
- Misses 10632 10650 +18
Partials 1669 1669
|
gammazero
approved these changes
Nov 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per ipfs/kubo#10593, if no one is reading from the channel returned by RecursiveKeys() and the context is cancelled, streamIndex will hang indefinitely.
Proposed fix is to always select when attempting to write to the
outchannel. If the context is done and there is no one to read, we can abort.