Skip to content

chore: minor Improvements to providerquerymanager - #728

Merged
gammazero merged 11 commits into
mainfrom
improve-providerquerymanager
Nov 27, 2024
Merged

gammazero merged 11 commits into
mainfrom
improve-providerquerymanager

Conversation

@gammazero

@gammazero gammazero commented Nov 26, 2024 •

Copy link
Copy Markdown
Contributor

Each of the first 5 commits is a stand-alone enhancement.

@gammazero
gammazero requested a review from a team as a code owner November 26, 2024 06:40
@gammazero
gammazero requested a review from hsanjuan November 26, 2024 06:40
@codecov

codecov Bot commented Nov 26, 2024 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 93.10345% with 4 lines in your changes missing coverage. Please review.

Project coverage is 60.32%. Comparing base (8673560) to head (e2965ed).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...uting/providerquerymanager/providerquerymanager.go 93.10% 3 Missing and 1 partial ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #728      +/-   ##
==========================================
+ Coverage   60.31%   60.32%   +0.01%     
==========================================
  Files         244      244              
  Lines       31034    31015      -19     
==========================================
- Hits        18717    18711       -6     
+ Misses      10644    10633      -11     
+ Partials     1673     1671       -2     
Files with missing lines Coverage Ξ”
...uting/providerquerymanager/providerquerymanager.go 89.18% <93.10%> (+2.20%) ⬆️

... and 6 files with indirect coverage changes

A counting semaphore is used to liimit the number of concurrent find requests, instead of a fixed number of goroutines. If the configured limit is set to 0, meaning unlimited, then ignore the semaphore.

@hsanjuan hsanjuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... although I think the improvements may be not so minor ;)

@gammazero
gammazero merged commit 821f539 into main Nov 27, 2024
@gammazero
gammazero deleted the improve-providerquerymanager branch November 27, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants