Skip to content

[skip changelog] bitswap/client: fix wiring when passing custom providerFinder - #732

Merged
hsanjuan merged 2 commits into
mainfrom
fix/pqm-wiring
Nov 29, 2024
Merged

hsanjuan merged 2 commits into
mainfrom
fix/pqm-wiring

Conversation

@hsanjuan

Copy link
Copy Markdown
Contributor

When passing in a custom provider finder, we need to pass it to the session. We were not doing that, so lookups were effectively disabled in that case.

@hsanjuan
hsanjuan requested a review from a team as a code owner November 28, 2024 16:29
@hsanjuan hsanjuan self-assigned this Nov 28, 2024
@hsanjuan

Copy link
Copy Markdown
Contributor Author

I will add a test tomorrow

@ipfs ipfs deleted a comment from codecov Bot Nov 28, 2024
@codecov

codecov Bot commented Nov 28, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 60.38%. Comparing base (33c7b9c) to head (a6723bf).
Report is 3 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #732      +/-   ##
==========================================
+ Coverage   60.34%   60.38%   +0.03%     
==========================================
  Files         244      244              
  Lines       31026    31028       +2     
==========================================
+ Hits        18723    18735      +12     
+ Misses      10634    10623      -11     
- Partials     1669     1670       +1     
Files with missing lines Coverage Ξ”
bitswap/client/client.go 87.59% <100.00%> (-0.65%) ⬇️

... and 13 files with indirect coverage changes

@hsanjuan
hsanjuan enabled auto-merge November 29, 2024 11:00
@hsanjuan
hsanjuan merged commit ef02abc into main Nov 29, 2024
@gammazero
gammazero deleted the fix/pqm-wiring branch November 30, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants