Repository navigation
[skip changelog] bitswap/client: fix wiring when passing custom providerFinder - #732
Merged
Merged
Conversation
Contributor
Author
|
I will add a test tomorrow |
hsanjuan
force-pushed
the
fix/pqm-wiring
branch
from
November 28, 2024 16:33
0fb2761 to
b5656aa
Compare
Codecov ReportAll modified and coverable lines are covered by tests β
@@ Coverage Diff @@
## main #732 +/- ##
==========================================
+ Coverage 60.34% 60.38% +0.03%
==========================================
Files 244 244
Lines 31026 31028 +2
==========================================
+ Hits 18723 18735 +12
+ Misses 10634 10623 -11
- Partials 1669 1670 +1
|
gammazero
approved these changes
Nov 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When passing in a custom provider finder, we need to pass it to the session. We were not doing that, so lookups were effectively disabled in that case.