Skip to content

chore: minor examples cleanup - #736

Merged
gammazero merged 1 commit into
mainfrom
examples-cleanup
Dec 2, 2024
Merged

gammazero merged 1 commit into
mainfrom
examples-cleanup

Conversation

@gammazero

Copy link
Copy Markdown
Contributor
  • Pass time.Duration instead of passing int that gets converted to time.Duration.
  • Remove unneeded else clauses
  • spelling

- Pass time.Duration instead of passing int that gets converted to time.Duration.
- Remove unneeded else clauses
- spelling
@gammazero
gammazero requested a review from a team as a code owner December 2, 2024 22:48
@codecov

codecov Bot commented Dec 2, 2024 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.37%. Comparing base (caa6763) to head (89c8b8c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
examples/routing/delegated-routing-client/main.go 62.50% 3 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #736      +/-   ##
==========================================
- Coverage   60.40%   60.37%   -0.03%     
==========================================
  Files         244      244              
  Lines       31028    31029       +1     
==========================================
- Hits        18741    18735       -6     
- Misses      10617    10624       +7     
  Partials     1670     1670              
Files with missing lines Coverage Δ
examples/routing/delegated-routing-client/main.go 55.65% <62.50%> (+1.26%) ⬆️

... and 14 files with indirect coverage changes

@gammazero
gammazero merged commit 984fa89 into main Dec 2, 2024
@gammazero
gammazero deleted the examples-cleanup branch December 2, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant