Skip to content

Bitswap default ProviderQueryManager uses explicit options - #737

Merged
gammazero merged 2 commits into
mainfrom
use-defauls-for-default-pqm
Dec 3, 2024
Merged

gammazero merged 2 commits into
mainfrom
use-defauls-for-default-pqm

Conversation

@gammazero

@gammazero gammazero commented Dec 3, 2024 •

Copy link
Copy Markdown
Contributor

Set explicit options for bitswap default PQM, to make it more conservative and isolate it from a PQM without options.

When specifying that the bitswap client should use the default ProviderQueryManager, to wrap the router passed in, use the existing defaults for ProviderQueryManager and so not supply non-default options.
@gammazero
gammazero requested a review from a team as a code owner December 3, 2024 00:28
@codecov

codecov Bot commented Dec 3, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.41%. Comparing base (984fa89) to head (98e9778).
Report is 2 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #737      +/-   ##
==========================================
+ Coverage   60.34%   60.41%   +0.07%     
==========================================
  Files         244      244              
  Lines       31029    31032       +3     
==========================================
+ Hits        18723    18747      +24     
+ Misses      10634    10618      -16     
+ Partials     1672     1667       -5     
Files with missing lines Coverage Δ
bitswap/client/client.go 87.72% <100.00%> (+0.13%) ⬆️

... and 8 files with indirect coverage changes

Comment thread bitswap/client/client.go Resolved
…ative and isolate it from a PQM without options
@gammazero gammazero changed the title Defauld ProviderQueryManager uses its default settings. Bitswap default ProviderQueryManager uses explicit options Dec 3, 2024
@gammazero
gammazero merged commit 9069a29 into main Dec 3, 2024
@gammazero
gammazero deleted the use-defauls-for-default-pqm branch December 3, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants