Repository navigation
removed Startup function from ProviderQueryManager - #741
Merged
Merged
Conversation
Now `providerquerymanager.New` creates a `ProvicerQueryManager` that is already started. There is no use case for starting PQM at a later time than it is created. Removing the need to call a `Statup` function separately from `New` is more convenient and reduces the opportunity for a problem if calling `Startup` is missed or if called multiple times.
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #741 +/- ##
==========================================
+ Coverage 60.30% 60.42% +0.12%
==========================================
Files 241 245 +4
Lines 30980 31063 +83
==========================================
+ Hits 18681 18770 +89
+ Misses 10627 10622 -5
+ Partials 1672 1671 -1
|
gammazero
force-pushed
the
no-pqm-startup
branch
from
December 4, 2024 21:23
f8419fb to
907fad9
Compare
gammazero
force-pushed
the
no-pqm-startup
branch
from
December 5, 2024 00:23
56885a8 to
1483026
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes
providerquerymanager.Newto create aProvicerQueryManagerthat is already started.There is no use case for starting PQM at a later time than it is created. Removing the need to call a
Statupfunction separately fromNewis more convenient and reduces the opportunity for a problem if callingStartupis missed or if called multiple times.