Skip to content

removed Startup function from ProviderQueryManager - #741

Merged
gammazero merged 4 commits into
mainfrom
no-pqm-startup
Dec 5, 2024
Merged

gammazero merged 4 commits into
mainfrom
no-pqm-startup

Conversation

@gammazero

@gammazero gammazero commented Dec 4, 2024 •

Copy link
Copy Markdown
Contributor

This PR changes providerquerymanager.New to create a ProvicerQueryManager that is already started.

There is no use case for starting PQM at a later time than it is created. Removing the need to call a Statup function separately from New is more convenient and reduces the opportunity for a problem if calling Startup is missed or if called multiple times.

@gammazero
gammazero requested a review from a team as a code owner December 4, 2024 21:17
Now `providerquerymanager.New` creates a `ProvicerQueryManager` that is already started.

There is no use case for starting PQM at a later time than it is created. Removing the need to call a `Statup` function separately from `New` is more convenient and reduces the opportunity for a problem if calling `Startup` is missed or if called multiple times.
@codecov

codecov Bot commented Dec 4, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.42%. Comparing base (e9446bb) to head (51c7ba7).
Report is 1 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #741      +/-   ##
==========================================
+ Coverage   60.30%   60.42%   +0.12%     
==========================================
  Files         241      245       +4     
  Lines       30980    31063      +83     
==========================================
+ Hits        18681    18770      +89     
+ Misses      10627    10622       -5     
+ Partials     1672     1671       -1     
Files with missing lines Coverage Δ
bitswap/client/client.go 87.68% <ø> (-2.22%) ⬇️
...uting/providerquerymanager/providerquerymanager.go 87.86% <100.00%> (ø)

... and 18 files with indirect coverage changes

@gammazero
gammazero merged commit f6befaf into main Dec 5, 2024
@gammazero
gammazero deleted the no-pqm-startup branch December 5, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant