Repository navigation
blockstore/blockservice: change option to WriteThrough(enabled bool) - #749
Merged
Merged
Conversation
This allows passing in a boolean to indicate if we want to use the option or not, which provides better ergonomics for initialization.
hsanjuan
force-pushed
the
feat/writethrough-bool
branch
from
December 11, 2024 09:53
5b55c0e to
f9bac13
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #749 +/- ##
=======================================
Coverage 60.40% 60.41%
=======================================
Files 245 245
Lines 31063 31063
=======================================
+ Hits 18764 18767 +3
+ Misses 10629 10628 -1
+ Partials 1670 1668 -2
|
gammazero
approved these changes
Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows passing in a boolean to indicate if we want to use the option or not, which provides better ergonomics for initialization.