Skip to content

blockstore/blockservice: change option to WriteThrough(enabled bool) - #749

Merged
hsanjuan merged 1 commit into
mainfrom
feat/writethrough-bool
Dec 12, 2024
Merged

hsanjuan merged 1 commit into
mainfrom
feat/writethrough-bool

Conversation

@hsanjuan

Copy link
Copy Markdown
Contributor

This allows passing in a boolean to indicate if we want to use the option or not, which provides better ergonomics for initialization.

@hsanjuan
hsanjuan requested a review from a team as a code owner December 11, 2024 09:25
@hsanjuan
hsanjuan requested a review from gammazero December 11, 2024 09:51
This allows passing in a boolean to indicate if we want to use the option or
not, which provides better ergonomics for initialization.
@hsanjuan
hsanjuan force-pushed the feat/writethrough-bool branch from 5b55c0e to f9bac13 Compare December 11, 2024 09:53
@codecov

codecov Bot commented Dec 11, 2024 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.41%. Comparing base (7c459af) to head (f9bac13).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
blockstore/blockstore.go 0.00% 2 Missing ⚠️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #749   +/-   ##
=======================================
  Coverage   60.40%   60.41%           
=======================================
  Files         245      245           
  Lines       31063    31063           
=======================================
+ Hits        18764    18767    +3     
+ Misses      10629    10628    -1     
+ Partials     1670     1668    -2     
Files with missing lines Coverage Δ
blockservice/blockservice.go 78.23% <100.00%> (ø)
blockstore/blockstore.go 57.97% <0.00%> (ø)

... and 11 files with indirect coverage changes

@hsanjuan
hsanjuan merged commit 0c321cc into main Dec 12, 2024
@gammazero
gammazero deleted the feat/writethrough-bool branch July 5, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants