Repository navigation
improve mfs republisher - #754
Conversation
gammazero
commented
Dec 13, 2024
- Get updated values while retrying to publish
- Prefer Close to lifecycle context
- Do not require call to Start separate from New
- Get updated values while retrying to publish - Prefer Close to lifecycle context - Do not require call to Start separate from New
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #754 +/- ##
==========================================
- Coverage 60.38% 60.38% -0.01%
==========================================
Files 245 245
Lines 31063 31081 +18
==========================================
+ Hits 18758 18768 +10
- Misses 10634 10644 +10
+ Partials 1671 1669 -2
|
hsanjuan
left a comment
There was a problem hiding this comment.
part of me wonders if something similar cannot be achieved with a single timer that is reset for long/short intervals depending how the publishing went.
As far as I can see both timers are needed. It like when batching by count: you need to know both the batch size and how many values are in the batch so far. This is batching, but with time. The quick timer (waiting for additional results) keeps getting reset when another result arrives. If new results are coming in continuously, resetting quick timer each time, there needs to be another timer running that will trigger an update at some point even though new values keep arriving. In other words, the quick timeout means there are no more values to put into the "batch", so do update. The long timeout means there are that the "batch" is full, so do update, even though there are still values (no quick timeout yet) arriving. |