Skip to content

Fix leak due to cid queue never getting cleaned up - #756

Merged
gammazero merged 3 commits into
mainfrom
fix-leak-in-sessionwants
Dec 17, 2024
Merged

gammazero merged 3 commits into
mainfrom
fix-leak-in-sessionwants

Conversation

@gammazero

@gammazero gammazero commented Dec 16, 2024 •

Copy link
Copy Markdown
Contributor

This removes entries from the queue portion of CidQueue that were removed from the map portion.

Credit to @Wondertan for finding and proposing fix.

@gammazero
gammazero requested a review from a team as a code owner December 16, 2024 18:34
This removes entries from the queue portion of CidQueue that were removed from the map portion.
@gammazero
gammazero force-pushed the fix-leak-in-sessionwants branch from a36ffa2 to 8b25b78 Compare December 16, 2024 18:37
@codecov

codecov Bot commented Dec 16, 2024 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.55%. Comparing base (e11e4ed) to head (cdc19ae).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
bitswap/client/internal/session/sessionwants.go 92.30% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #756      +/-   ##
==========================================
+ Coverage   60.48%   60.55%   +0.07%     
==========================================
  Files         245      245              
  Lines       31102    31102              
==========================================
+ Hits        18813    18835      +22     
+ Misses      10621    10598      -23     
- Partials     1668     1669       +1     
Files with missing lines Coverage Ξ”
...ernal/blockpresencemanager/blockpresencemanager.go 96.80% <100.00%> (+3.40%) ⬆️
bitswap/client/internal/session/cidqueue.go 90.00% <100.00%> (+38.71%) ⬆️
bitswap/client/internal/session/sessionwants.go 89.56% <92.30%> (+0.57%) ⬆️

... and 12 files with indirect coverage changes

@gammazero
gammazero requested a review from hsanjuan December 17, 2024 20:43
@gammazero

gammazero commented Dec 17, 2024 •

Copy link
Copy Markdown
Contributor Author

@hsanjuan I think my latest change satisfies what you were asking for. I will merge this PR in a bit unless you have any objections.

@gammazero
gammazero merged commit 00f508d into main Dec 17, 2024
@gammazero
gammazero deleted the fix-leak-in-sessionwants branch December 17, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants