Repository navigation
Fix leak due to cid queue never getting cleaned up - #756
Merged
Merged
Conversation
This removes entries from the queue portion of CidQueue that were removed from the map portion.
gammazero
force-pushed
the
fix-leak-in-sessionwants
branch
from
December 16, 2024 18:37
a36ffa2 to
8b25b78
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #756 +/- ##
==========================================
+ Coverage 60.48% 60.55% +0.07%
==========================================
Files 245 245
Lines 31102 31102
==========================================
+ Hits 18813 18835 +22
+ Misses 10621 10598 -23
- Partials 1668 1669 +1
|
hsanjuan
requested changes
Dec 17, 2024
Contributor
Author
|
@hsanjuan I think my latest change satisfies what you were asking for. I will merge this PR in a bit unless you have any objections. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes entries from the queue portion of CidQueue that were removed from the map portion.
Credit to @Wondertan for finding and proposing fix.