Repository navigation
Remove peer's count of first responses when peer becomes unavailable - #757
Merged
Merged
Conversation
The peer response tracker counts the times each peer is first to response to block requests. When a peer becomes unavailabile, its count of first responses should be removed. This way we are not tracking the first response count for peers that are no longer available.
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #757 +/- ##
==========================================
+ Coverage 60.37% 60.47% +0.10%
==========================================
Files 245 245
Lines 31114 31117 +3
==========================================
+ Hits 18784 18818 +34
+ Misses 10654 10633 -21
+ Partials 1676 1666 -10
|
hsanjuan
approved these changes
Dec 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The peer response tracker counts the times each peer is first to response to block requests. When a peer becomes unavailabile, its count of first responses should be removed. This way we are not tracking the first response count for peers that are no longer available.