Skip to content

Remove peer's count of first responses when peer becomes unavailable - #757

Merged
gammazero merged 2 commits into
mainfrom
reset-peer-rsp-trkr
Dec 17, 2024
Merged

gammazero merged 2 commits into
mainfrom
reset-peer-rsp-trkr

Conversation

@gammazero

Copy link
Copy Markdown
Contributor

The peer response tracker counts the times each peer is first to response to block requests. When a peer becomes unavailabile, its count of first responses should be removed. This way we are not tracking the first response count for peers that are no longer available.

The peer response tracker counts the times each peer is first to response to block requests. When a peer becomes unavailabile, its count of first responses should be removed. This way we are not tracking the first response count for peers that are no longer available.
@gammazero
gammazero requested a review from a team as a code owner December 16, 2024 19:26
@codecov

codecov Bot commented Dec 16, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.47%. Comparing base (8854a6f) to head (28cd43f).
Report is 1 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #757      +/-   ##
==========================================
+ Coverage   60.37%   60.47%   +0.10%     
==========================================
  Files         245      245              
  Lines       31114    31117       +3     
==========================================
+ Hits        18784    18818      +34     
+ Misses      10654    10633      -21     
+ Partials     1676     1666      -10     
Files with missing lines Coverage Δ
...wap/client/internal/session/peerresponsetracker.go 96.42% <100.00%> (+0.27%) ⬆️
...tswap/client/internal/session/sessionwantsender.go 97.65% <100.00%> (+1.41%) ⬆️

... and 15 files with indirect coverage changes

@gammazero
gammazero merged commit a83de68 into main Dec 17, 2024
@gammazero
gammazero deleted the reset-peer-rsp-trkr branch December 17, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants