Repository navigation
Do not reset the broadcast timer if there are no wants - #758
Merged
Merged
Conversation
This change removes unnecessary timer activity and calls to broadcast.
Codecov ReportAll modified and coverable lines are covered by tests β
@@ Coverage Diff @@
## main #758 +/- ##
==========================================
+ Coverage 60.40% 60.44% +0.03%
==========================================
Files 245 245
Lines 31101 31102 +1
==========================================
+ Hits 18787 18799 +12
+ Misses 10641 10632 -9
+ Partials 1673 1671 -2
|
gammazero
enabled auto-merge (squash)
December 17, 2024 20:38
gammazero
disabled auto-merge
December 17, 2024 20:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes unnecessary timer activity and calls to broadcast.
Credit to @Wondertan for finding and proposing fix.