Skip to content

chore: pass options to tracer start - #775

Merged
gammazero merged 2 commits into
ipfs:mainfrom
Dreamacro:missing-passthrough
Jan 8, 2025
Merged

gammazero merged 2 commits into
ipfs:mainfrom
Dreamacro:missing-passthrough

Conversation

@Dreamacro

Copy link
Copy Markdown
Contributor

When I was reading the code, I found the problem of missing parameters. Maybe boxo needs a static checking tool like golangci-lint to standardize the code?

I can also change this pr to add a static checking tool and fix the lint if needed

@Dreamacro
Dreamacro requested a review from a team as a code owner December 25, 2024 09:02
@codecov

codecov Bot commented Dec 25, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.46%. Comparing base (ae7ab1f) to head (fd13853).
Report is 1 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #775      +/-   ##
==========================================
- Coverage   60.47%   60.46%   -0.02%     
==========================================
  Files         245      245              
  Lines       31133    31133              
==========================================
- Hits        18829    18825       -4     
- Misses      10629    10633       +4     
  Partials     1675     1675              
Files with missing lines Coverage Δ
namesys/republisher/repub.go 61.26% <100.00%> (ø)

... and 13 files with indirect coverage changes

@Dreamacro Dreamacro changed the title [skip changelog] chore: pass options to tracer start chore: pass options to tracer start Jan 4, 2025
@gammazero
gammazero merged commit 13869e2 into ipfs:main Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants