Repository navigation
Conversation
A couple of locks here seem to lock also while doing things like sending things on channels. This seems prone to deadlocks and is wasteful.
Codecov ReportAll modified and coverable lines are covered by tests β
@@ Coverage Diff @@
## main #787 +/- ##
==========================================
+ Coverage 60.46% 60.48% +0.01%
==========================================
Files 245 245
Lines 31133 31138 +5
==========================================
+ Hits 18826 18834 +8
- Misses 10627 10629 +2
+ Partials 1680 1675 -5
|
gammazero
approved these changes
Jan 15, 2025
gammazero
left a comment
Contributor
There was a problem hiding this comment.
The last unlock may be important if this ever blocks:
mq.events <- messageFinishedSending
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of locks here seem to lock also while doing things like sending things on channels. This seems prone to deadlocks and is wasteful.