Repository navigation
reduce default number of routing in-process requests - #793
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests β
@@ Coverage Diff @@
## main #793 +/- ##
==========================================
- Coverage 60.51% 60.47% -0.04%
==========================================
Files 245 245
Lines 31132 31130 -2
==========================================
- Hits 18840 18827 -13
- Misses 10615 10625 +10
- Partials 1677 1678 +1
|
hsanjuan
approved these changes
Jan 17, 2025
gammazero
commented
Jan 17, 2025
Reduce the routing ProviderQueryManager default MaxInProcessRequests from 16 to 8. This prevents a situation where goroutines can be created faster than they can be completed, leading to OOM.
gammazero
force-pushed
the
reduce-routing-max-concurrent-reqs
branch
from
January 17, 2025 16:34
cffe691 to
ae840a2
Compare
gammazero
commented
Jan 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce the routing ProviderQueryManager default MaxInProcessRequests from 16 to 8. This prevents a situation where goroutines can be created faster than they can be completed, leading to OOM.