Skip to content

reduce default number of routing in-process requests - #793

Merged
gammazero merged 4 commits into
mainfrom
reduce-routing-max-concurrent-reqs
Jan 20, 2025
Merged

gammazero merged 4 commits into
mainfrom
reduce-routing-max-concurrent-reqs

Conversation

@gammazero

Copy link
Copy Markdown
Contributor

Reduce the routing ProviderQueryManager default MaxInProcessRequests from 16 to 8. This prevents a situation where goroutines can be created faster than they can be completed, leading to OOM.

@gammazero
gammazero requested a review from a team as a code owner January 17, 2025 08:24
@codecov

codecov Bot commented Jan 17, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 60.47%. Comparing base (8ca0ca2) to head (a2d9527).
Report is 1 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #793      +/-   ##
==========================================
- Coverage   60.51%   60.47%   -0.04%     
==========================================
  Files         245      245              
  Lines       31132    31130       -2     
==========================================
- Hits        18840    18827      -13     
- Misses      10615    10625      +10     
- Partials     1677     1678       +1     
Files with missing lines Coverage Ξ”
bitswap/client/client.go 86.61% <100.00%> (-2.20%) ⬇️
...uting/providerquerymanager/providerquerymanager.go 85.76% <100.00%> (-0.98%) ⬇️

... and 4 files with indirect coverage changes

Comment thread bitswap/client/client.go Resolved
Reduce the routing ProviderQueryManager default MaxInProcessRequests from 16 to 8. This prevents a situation where goroutines can be created faster than they can be completed, leading to OOM.
@gammazero
gammazero force-pushed the reduce-routing-max-concurrent-reqs branch from cffe691 to ae840a2 Compare January 17, 2025 16:34
@gammazero
gammazero merged commit de52bc8 into main Jan 20, 2025
@gammazero
gammazero deleted the reduce-routing-max-concurrent-reqs branch January 20, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants