Repository navigation
prefer slices.SortFunc to sort.Sort - #796
Merged
Merged
Conversation
In many situations, the newer `slices.SortFunc` function is more ergonomic and runs faster than `sort.Sort`. Using `slices.SortFunc` also avoids having to define custom slice types to make slices of objects sortable.
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #796 +/- ##
==========================================
- Coverage 60.53% 60.47% -0.07%
==========================================
Files 245 245
Lines 31130 31124 -6
==========================================
- Hits 18846 18823 -23
- Misses 10608 10623 +15
- Partials 1676 1678 +2
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In many situations, the newer
slices.SortFuncfunction is more ergonomic and runs faster thansort.Sort. Usingslices.SortFuncalso avoids having to define custom slice types to make slices of objects sortable.