Skip to content

fix potential crash in unixfs directory - #798

Merged
gammazero merged 3 commits into
mainfrom
fix-sizebeloadthreshold
Jan 21, 2025
Merged

gammazero merged 3 commits into
mainfrom
fix-sizebeloadthreshold

Conversation

@gammazero

Copy link
Copy Markdown
Contributor

Fix potential crash in sizeBelowThreshold when modifying children in a directory.

Closes #675

@gammazero
gammazero requested a review from a team as a code owner January 20, 2025 20:06
@codecov

codecov Bot commented Jan 20, 2025 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.

Project coverage is 60.53%. Comparing base (bcf475c) to head (9256fbe).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ipld/unixfs/io/directory.go 72.22% 4 Missing and 1 partial ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #798      +/-   ##
==========================================
+ Coverage   60.49%   60.53%   +0.03%     
==========================================
  Files         245      245              
  Lines       31124    31134      +10     
==========================================
+ Hits        18830    18848      +18     
+ Misses      10615    10610       -5     
+ Partials     1679     1676       -3     
Files with missing lines Coverage Ξ”
ipld/unixfs/io/directory.go 68.94% <72.22%> (+0.03%) ⬆️

... and 14 files with indirect coverage changes

@gammazero gammazero changed the title fix potential crahs in unixfs directory fix potential crash in unixfs directory Jan 20, 2025
@gammazero
gammazero force-pushed the fix-sizebeloadthreshold branch from 88864ce to 53980fa Compare January 21, 2025 04:41
@gammazero

Copy link
Copy Markdown
Contributor Author

Needs test

Fix potential crash in sizeBelowThreshold when modifying children in a directory.

Closes #675
@gammazero
gammazero force-pushed the fix-sizebeloadthreshold branch from 53980fa to b634709 Compare January 21, 2025 06:36
@gammazero
gammazero force-pushed the fix-sizebeloadthreshold branch from b634709 to 9256fbe Compare January 21, 2025 06:38
@lidel

lidel commented Jan 21, 2025

Copy link
Copy Markdown
Contributor

Triage notes:

  • ok to merge as long there is Kubo PR using this PR and the CI there is green (there are autosharding tests in Kubo iirc that should catch any unexpected regression)

@gammazero
gammazero merged commit afe6e24 into main Jan 21, 2025
@gammazero
gammazero deleted the fix-sizebeloadthreshold branch January 21, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash in sizeBelowThreshold

2 participants