Repository navigation
provider: simplify reprovide - #890
Conversation
e7bea46 to
ecd5683
Compare
ecd5683 to
46fab87
Compare
gammazero
left a comment
There was a problem hiding this comment.
As noted by @aschmahmann : If your node reboots do you re-advertise all your data again even if it's within the reprovide interval?
If this is an intended behavior change then it should be documetned in release notes.
Right, I missed why the reprovide times were persisted to the datastore. I reverted and documented this behavior. I also corrected a corner case. Previously, a node rebooting, that would have have to reprovide in In the fix, the first provide is either Added a changelog entry, since this last change actually modifies the behavior. |
Follow up to #871 and part of ipshipyard/roadmaps#6 / ipshipyard/roadmaps#7
Hopefully it will help with ipfs/kubo#10714Previous behavior was hanging on a
selectwaiting for context to be cancelled.If the warning messageπππ YOU ARE FALLING BEHIND DHT REPROVIDES! πππkeeps coming, while thereprovideIntervalis set to0, it means thatReprovidewas called (probably fromkubo, withipfs routing reprovide?).EDIT: the reprovide warning issue seems to come from
kubo