Skip to content

gateway: validate against subdomains with IP addresses - #903

Merged
lidel merged 4 commits into
ipfs:mainfrom
gitsrc:feat_support_issue_902
Apr 8, 2025
Merged

lidel merged 4 commits into
ipfs:mainfrom
gitsrc:feat_support_issue_902

Conversation

@gitsrc

@gitsrc gitsrc commented Mar 28, 2025 •

Copy link
Copy Markdown
Contributor

Prevent invalid configurations where UseSubdomains=true is set with IP addresses.

Changes:

  • Added validation in prepareHostnameGateways() to check for IP addresses when UseSubdomains is enabled
  • Invalid configurations are skipped with a warning log

Closes #902

gitsrc added 2 commits March 28, 2025 18:52
Signed-off-by: gitsrc <34047788+gitsrc@users.noreply.github.com>
Signed-off-by: gitsrc <34047788+gitsrc@users.noreply.github.com>
@gitsrc
gitsrc requested review from a team and lidel as code owners March 28, 2025 11:03
@gammazero

Copy link
Copy Markdown
Contributor

Would you be able to write a test for this PR as well?

@gammazero gammazero added the need/author-input Needs input from the original author label Apr 1, 2025
Signed-off-by: gitsrc <34047788+gitsrc@users.noreply.github.com>
@gitsrc

gitsrc commented Apr 5, 2025

Copy link
Copy Markdown
Contributor Author

Would you be able to write a test for this PR as well?

ok

@lidel lidel self-assigned this Apr 8, 2025
Comment thread CHANGELOG.md Resolved

@lidel lidel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

need/author-input Needs input from the original author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gateway: error when host is IP and UseSubdomains=true

3 participants