Skip to content

bitswap/client: disable use of traceability block by default - #956

Merged
gammazero merged 12 commits into
mainfrom
disable-traceability
Jul 24, 2025
Merged

gammazero merged 12 commits into
mainfrom
disable-traceability

Conversation

@gammazero

@gammazero gammazero commented Jun 19, 2025 •

Copy link
Copy Markdown
Contributor

The bitswap client's traceability.Block is now disabled by default. It is only used for testing and debugging and is not needed for typical operation. Using it costs additional allocation. To enable traceability.Block, use the bitswap client option WithTraceBlock(true).

The bitswap client's [`traceability.Block`](https://github.com/ipfs/boxo/blob/main/bitswap/client/traceability/block.go) is now disabled by default. It is only used for testing an debugging and is not needed for typical operation. Using it costs additional allocation. To enable `traceability.Block`, use the bitswap client option `WithTraceBlock(true)`.
@gammazero
gammazero requested a review from a team as a code owner June 19, 2025 03:04
@codecov

codecov Bot commented Jun 19, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 61.58%. Comparing base (6a7b42f) to head (263020d).
Report is 1 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #956      +/-   ##
==========================================
+ Coverage   61.54%   61.58%   +0.03%     
==========================================
  Files         254      254              
  Lines       31493    31504      +11     
==========================================
+ Hits        19382    19401      +19     
+ Misses      10521    10518       -3     
+ Partials     1590     1585       -5     
Files with missing lines Coverage Ξ”
bitswap/client/client.go 78.22% <100.00%> (+0.58%) ⬆️
...wap/client/internal/notifications/notifications.go 92.55% <100.00%> (+5.19%) ⬆️

... and 8 files with indirect coverage changes

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@guillaumemichel
guillaumemichel self-requested a review July 22, 2025 14:49

@guillaumemichel guillaumemichel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A few nits

Comment thread bitswap/client/client.go Resolved
Comment thread bitswap/client/client.go Resolved
gammazero and others added 4 commits July 24, 2025 09:50
Co-authored-by: Guillaume Michel <guillaumemichel@users.noreply.github.com>
Co-authored-by: Guillaume Michel <guillaumemichel@users.noreply.github.com>
@gammazero
gammazero merged commit 7758521 into main Jul 24, 2025
@gammazero
gammazero deleted the disable-traceability branch July 24, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants