Skip to content

Expect upper-case hex digits in escaped redirect URL - #225

Merged
gammazero merged 2 commits into
mainfrom
updated-redirect-urls
Jan 3, 2025
Merged

gammazero merged 2 commits into
mainfrom
updated-redirect-urls

Conversation

@gammazero

@gammazero gammazero commented Jan 2, 2025 •

Copy link
Copy Markdown
Contributor

This is needed for ipfs/boxo#779.

Regardless of boxo changes it seems more correct to expect upper-case hex for percent-escaped characters:

RFC3986 Β§2.1

For consistency, URI producers and normalizers should use uppercase hexadecimal digits for all percent-encodings.

@github-actions

github-actions Bot commented Jan 2, 2025

Copy link
Copy Markdown
Contributor

Results against Kubo master:
(check the action's summary for the full results)

Summary

Tests Failures Errors Skipped
1308 6 0 0

@github-actions

github-actions Bot commented Jan 2, 2025

Copy link
Copy Markdown
Contributor

Results against Kubo latest:
(check the action's summary for the full results)

Summary

Tests Failures Errors Skipped
1308 6 0 0

@gammazero gammazero changed the title Handle boxo changes to redirect URL Expect upper-case hex digits in escaped redirect URL Jan 2, 2025
@gammazero
gammazero merged commit 4bb55f3 into main Jan 3, 2025
@gammazero
gammazero deleted the updated-redirect-urls branch January 3, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant