Skip to content

fix(errors): preserve stack tail in report url - #3152

Merged
lidel merged 2 commits into
mainfrom
fix/error-report-stack-truncation
May 26, 2026
Merged

lidel merged 2 commits into
mainfrom
fix/error-report-stack-truncation

Conversation

@lidel

@lidel lidel commented May 6, 2026

Copy link
Copy Markdown
Contributor

new-issue urls were cut from the end at 1999 chars, hiding the real cause when daemon migration logs are wrapped in new Error(logs) (see #3147 where fs-repo-12-to-13/ve... were the last visible bytes).

this PR truncates smarter by keeping head and tail with a marker between, and raise the url cap to 8000 chars; confirmed this works in both Firefox and Chrome, and that empirical github server ceiling is 8191.

  • src/dialogs/errors.js: head+tail stack truncation, MAX_URL_LENGTH 8000, encodeURIComponent for query values, fix issueTitle when stack has no newline
  • test/unit/errors.spec.js: cover length cap, tail preservation, truncation marker, faq routing, special-char encoding

new-issue urls were cut from the end at 1999 chars, hiding the real
cause when daemon migration logs are wrapped in new Error(logs) (see
#3147 where fs-repo-12-to-13/ve... were the last visible bytes).
truncate by keeping head and tail with a marker between, and raise the
url cap to 8000 chars; empirical github nginx ceiling is 8191.

- src/dialogs/errors.js: head+tail stack truncation, MAX_URL_LENGTH
  8000, encodeURIComponent for query values, fix issueTitle when stack
  has no newline
- test/unit/errors.spec.js: cover length cap, tail preservation,
  truncation marker, faq routing, special-char encoding
@lidel
lidel requested a review from a team as a code owner May 6, 2026 19:08
@lidel
lidel merged commit 2874276 into main May 26, 2026
8 checks passed
@lidel
lidel deleted the fix/error-report-stack-truncation branch May 26, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants