Skip to content

Broken CID info for identity multihashesΒ #464

Closed

Description

@lidel

Inspecting a CID with identity multihash (like bafkqaddjnzzxazldoqwxizltoq or bafkqablimvwgy3y) produces error and breaks "CID info" section:

image

Activity

  1. added
    kind/bugA bug in existing code (including security flaws)
    P1High: Likely tackled by core team if no one steps up
    on Nov 29, 2024
  2. lidel commented on Nov 29, 2024

    @lidel
    ContributorAuthor

    I think maybe

    export type SupportedHashers = typeof sha2.sha256 |
    typeof sha2.sha512 |
    Hasher<'keccak-256', 27> |
    Hasher<'sha1', 17> |
    Hasher<'blake2b-256', 0xb220> |
    Hasher<'blake2b-512', 0xb240> |
    Hasher<'sha3-512', 20> |
    Hasher<'blake3', 30>

    is missing https://github.com/multiformats/js-multiformats/blob/master/src/hashes/identity.ts ?

    Anyway, @SgtPooki mind taking a look at this next week, and if easy to fix, tag a patch release? πŸ™

  3. added
    need/triageNeeds initial labeling and prioritization
    on Nov 29, 2024
  4. self-assigned this
    on Dec 2, 2024
  5. linked a pull request that will close this issuefix: identity hashes display object info #465on Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P1High: Likely tackled by core team if no one steps upkind/bugA bug in existing code (including security flaws)need/triageNeeds initial labeling and prioritization

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions