Skip to content

pinning taking up lots of CPU on benchmarks #1192

Closed

Description

@whyrusleeping

I was looking over the benchmarks for the dagmodifier since someone mentioned writing a large file into /ipns was slow, and i noticed that we are spending a lot of time right here: https://github.com/ipfs/go-ipfs/blob/master/pin/indirect.go#L46

We really shouldnt be marshaling keys to base58 for this...

@tv42 in your pinning stuff you were working on, you dont do any b58 marshaling, right?

Activity

  1. tv42 commented on May 3, 2015

    @tv42
    Contributor

    @whyrusleeping I consider needing base58 outside of UI a design failure.

  2. whyrusleeping commented on May 3, 2015

    @whyrusleeping
    MemberAuthor

    @tv42 good.

  3. whyrusleeping commented on Jan 2, 2016

    @whyrusleeping
    MemberAuthor

    this is much better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugA bug in existing code (including security flaws)topic/perfPerformance

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions