Skip to content

Add recover in ipfs mount command. #124

Closed

Description

@whyrusleeping

Ive found that if ipfs panics for any reason (as rare as that might be) the fuse stuff gets into a funky state since it wasnt properly dismounted, i wanted to discuss the pros and cons of having a recover statement in the ipfs mount command to catch those and safely unmount any mounted fuse systems.

Activity

  1. jbenet commented on Sep 25, 2014

    @jbenet
    Member

    Yep, SGTM. We should have proper teardown.—
    Sent from Mailbox

    On Wed, Sep 24, 2014 at 9:33 PM, Jeromy Johnson notifications@github.com
    wrote:

    Ive found that if ipfs panics for any reason (as rare as that might be) the fuse stuff gets into a funky state since it wasnt properly dismounted, i wanted to discuss the pros and cons of having a recover statement in the ipfs mount command to catch those and safely unmount any mounted fuse systems.

    Reply to this email directly or view it on GitHub:
    #124

  2. cryptix commented on Mar 23, 2015

    @cryptix
    Contributor

    I think we tackled most of these in #945 and can close this for now?

    cc @whyrusleeping reopen if I missed something.

  3. whyrusleeping commented on Mar 23, 2015

    @whyrusleeping
    MemberAuthor

    Ah, im fine with closing this. but this wasnt about race conditions, it was about fuse not being unmounted properly in the case of a panic

  4. cryptix commented on Mar 23, 2015

    @cryptix
    Contributor

    Oh... I switched cause and outcome here than.

    I wonder where a recover() could be placed. It would have to be somewhere blocking for ipfs to exit, right? The mount core command wouldn't work for that since they return to early.

  5. whyrusleeping commented on Mar 24, 2015

    @whyrusleeping
    MemberAuthor

    Yeah, i wasnt sure where to put it, which is why i never got around to doing it, lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions