You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ive found that if ipfs panics for any reason (as rare as that might be) the fuse stuff gets into a funky state since it wasnt properly dismounted, i wanted to discuss the pros and cons of having a recover statement in the ipfs mount command to catch those and safely unmount any mounted fuse systems.
Ive found that if ipfs panics for any reason (as rare as that might be) the fuse stuff gets into a funky state since it wasnt properly dismounted, i wanted to discuss the pros and cons of having a recover statement in the ipfs mount command to catch those and safely unmount any mounted fuse systems.
Reply to this email directly or view it on GitHub: #124
I wonder where a recover() could be placed. It would have to be somewhere blocking for ipfs to exit, right? The mount core command wouldn't work for that since they return to early.
Activity
jbenet commentedon Sep 25, 2014
Yep, SGTM. We should have proper teardown.—
Sent from Mailbox
On Wed, Sep 24, 2014 at 9:33 PM, Jeromy Johnson notifications@github.com
wrote:
cryptix commentedon Mar 23, 2015
I think we tackled most of these in #945 and can close this for now?
cc @whyrusleeping reopen if I missed something.
whyrusleeping commentedon Mar 23, 2015
Ah, im fine with closing this. but this wasnt about race conditions, it was about fuse not being unmounted properly in the case of a panic
cryptix commentedon Mar 23, 2015
Oh... I switched cause and outcome here than.
I wonder where a
recover()could be placed. It would have to be somewhere blocking for ipfs to exit, right? Themountcore command wouldn't work for that since they return to early.whyrusleeping commentedon Mar 24, 2015
Yeah, i wasnt sure where to put it, which is why i never got around to doing it, lol