Skip to content

Timing testsย #188

Closed
Closed

Description

@jbenet

Need to move away from timing tests, to something sync/mock based like: https://www.youtube.com/watch?v=ndmB0bj7eyw

Activity

  1. added
    help wantedSeeking public contribution on this issue
    and removed
    help wantedSeeking public contribution on this issue
    on Oct 19, 2014
  2. whyrusleeping commented on Jan 13, 2015

    @whyrusleeping
    Member

    I think we can probably close this now, our tests are much better in regards to relying on timers

  3. btc commented on Jan 14, 2015

    @btc
    Contributor

    https://build.protocol-dev.com/job/gotest/696/console

    failure at bd1d876

    ok github.com/jbenet/go-ipfs/p2p/net/mock 0.898s
    --- FAIL: TestDialBackoff (1.61 seconds)
    dial_test.go:103: new silent peer: <peer.ID QmUDmJ> /ip6/::1/tcp/54504
    dial_test.go:235: s2 should not happen immediately
    dial_test.go:252: s2 took too long
    dial_test.go:260: s3 should not happen yet
    dial_test.go:276: s3 took too long

  4. reopened this on Jan 14, 2015
  5. whyrusleeping commented on Jan 14, 2015

    @whyrusleeping
    Member

    hrm... thats a new one. Agreed on the reopen

  6. jbenet commented on Jan 14, 2015

    @jbenet
    MemberAuthor

    That's my fault. it's a timing test :( -- it's hard to do real network tests without using time. i'll try to rework it / make it more generous. maybe should add some signals inside the swarm functions itself.

  7. cryptix commented on Mar 4, 2015

    @cryptix
    Contributor

    Found another timing related one for the list: TestStBackpressureStreamWrite from p2p/test/backpressure.

  8. jbenet commented on Mar 10, 2015

    @jbenet
    MemberAuthor
    • TestBootstrap-- it so annoying.
  9. cryptix commented on Mar 12, 2015

    @cryptix
    Contributor
  10. jbenet commented on Oct 31, 2015

    @jbenet
    MemberAuthor

    Saw this one again:

    --- FAIL: TestBootstrap (0.56s)
        dht_test.go:303: connecting 30 dhts in a ring
        dht_test.go:79: dial attempt failed: misdial to <peer.ID NsEZww> through /ip4/127.0.0.1/tcp/51254 (got <peer.ID VnbQqa>)
    TestBogusPrivateKey.Sign -- this better be a test!
    FAIL
    FAIL    github.com/ipfs/go-ipfs/routing/dht 2.356s
    
  11. whyrusleeping commented on Jan 1, 2016

    @whyrusleeping
    Member

    TestBootstrap still fails occasionally... would love to get that one fixed up.

  12. added
    exp/expertHaving worked on the specific codebase is important
    and removed on Feb 2, 2016
  13. added
    help wantedSeeking public contribution on this issue
    and removed
    help wantedSeeking public contribution on this issue
    on May 31, 2016
  14. Kubuxu commented on Jun 15, 2016

    @Kubuxu
    Member

    Please reopen or create new issue if there are any more test failures.

  15. added a commit that references this issue on Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    exp/expertHaving worked on the specific codebase is importanthelp wantedSeeking public contribution on this issuekind/testTesting work

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions