Skip to content

vendoringΒ #28

Closed
Closed

Description

@guybrush

currently go get github.com/jbenet/go-ipfs/cmd/ipfs doesnt work because of breaking changes in gogoprotobuf, so maybe put deps in a vendor-directory?

https://botbot.me/freenode/ipfs/2014-08-15/?msg=19828336&page=1

Activity

  1. jbenet commented on Aug 16, 2014

    @jbenet
    Member

    Yeah we need to vendor everything.β€”
    Sent from Mailbox

    On Fri, Aug 15, 2014 at 10:11 PM, Patrick Pfeiffer
    notifications@github.com wrote:

    currently go get github.com/jbenet/go-ipfs/cmd/ipfs doesnt work because of breaking changes in gogoprotobuf, so maybe put deps in a vendor-directory?

    https://botbot.me/freenode/ipfs/2014-08-15/?msg=19828336&page=1

    Reply to this email directly or view it on GitHub:
    #28

  2. jbenet commented on Aug 17, 2014

    @jbenet
    Member

    best strategies? the way docker does it?

  3. guybrush commented on Aug 18, 2014

    @guybrush
    Author

    im a complete go-noob, without any experience. if you want me to i can put all the deps into github.com/jbenet/go-ipfs/vendor and also change all the import-paths. but it would be the first time i am doing this :D (for example im not sure if i should change import-paths inside vendor-dependencies?)

    i am currently looking into all the tools around golang, the dependency-management seems to be kind of rough (comming from nodejs&npm). there are tools to help with vendoring but none of them is ideal.

  4. whyrusleeping commented on Aug 18, 2014

    @whyrusleeping
    Member

    I feel like we should have an ipfs github organization for any vendoring we do.

  5. jbenet commented on Aug 20, 2014

    @jbenet
    Member

    Am not too keen on premature orgs -- they add a whole bunch of hassle up front. once we have many repos, sure. (For vendoring, we don't need repos. We should be vendoring like Docker + Camlistore do -- cloning into the repo). At least until we can host the code / package manager on IPFS. :)

  6. guybrush commented on Aug 20, 2014

    @guybrush
    Author

    i cant wait to host all the things in ipfs, like everything hahaha

    also i think vendoring like camli and docker is the best (no git-submodules)

    recently i saw another tool that might not be so bad, its used in kubernetes: https://github.com/GoogleCloudPlatform/kubernetes/tree/master/Godeps

  7. cryptix commented on Aug 20, 2014

    @cryptix
    Contributor

    I'd like suggest considering Godeps, too. If all you need is locking your dependencies to specific commits/tags/versions, Godep is a very nice solution. I think docker and camlistore chose their ways because no other mature solution was available when they started.

  8. whyrusleeping commented on Aug 20, 2014

    @whyrusleeping
    Member

    my issue with godeps is that its another external tool we have to be dependant on, vendoring the code is seamless and from the users perspective, no extra steps are required.

  9. whyrusleeping commented on Aug 20, 2014

    @whyrusleeping
    Member

    I also want to mention that vendoring gives us the power to update our dependencies without having to push any new commits to ipfs, having 400 commits saying "Updating godeps" seems like a messy solution to me

  10. guybrush commented on Aug 20, 2014

    @guybrush
    Author

    the reason for vendoring is to update dependencies by commit, isnt it?

    you want to be able to checkout a specific commit of ipfs and be sure to get exactly the same binary with go build everytime. even when upstream repositories of dependencies change, like it happened here (the reason why i opened this issue).

  11. jbenet commented on Aug 20, 2014

    @jbenet
    Member

    Yeah, we want it to be committed. Let's vendor the way docker + camlistore do it for now.

  12. whyrusleeping commented on Aug 20, 2014

    @whyrusleeping
    Member

    Ah, I get it now.

  13. btc commented on Sep 7, 2014

    @btc
    Contributor

    Please see: #35

  14. btc commented on Sep 11, 2014

    @btc
    Contributor

    Shall we close this issue?

  15. jbenet commented on Sep 11, 2014

    @jbenet
    Member

    yep

  16. added a commit that references this issue on Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions