You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
im a complete go-noob, without any experience. if you want me to i can put all the deps into github.com/jbenet/go-ipfs/vendor and also change all the import-paths. but it would be the first time i am doing this :D (for example im not sure if i should change import-paths inside vendor-dependencies?)
i am currently looking into all the tools around golang, the dependency-management seems to be kind of rough (comming from nodejs&npm). there are tools to help with vendoring but none of them is ideal.
Am not too keen on premature orgs -- they add a whole bunch of hassle up front. once we have many repos, sure. (For vendoring, we don't need repos. We should be vendoring like Docker + Camlistore do -- cloning into the repo). At least until we can host the code / package manager on IPFS. :)
I'd like suggest considering Godeps, too. If all you need is locking your dependencies to specific commits/tags/versions, Godep is a very nice solution. I think docker and camlistore chose their ways because no other mature solution was available when they started.
my issue with godeps is that its another external tool we have to be dependant on, vendoring the code is seamless and from the users perspective, no extra steps are required.
I also want to mention that vendoring gives us the power to update our dependencies without having to push any new commits to ipfs, having 400 commits saying "Updating godeps" seems like a messy solution to me
the reason for vendoring is to update dependencies by commit, isnt it?
you want to be able to checkout a specific commit of ipfs and be sure to get exactly the same binary with go build everytime. even when upstream repositories of dependencies change, like it happened here (the reason why i opened this issue).
Activity
jbenet commentedon Aug 16, 2014
Yeah we need to vendor everything.β
Sent from Mailbox
On Fri, Aug 15, 2014 at 10:11 PM, Patrick Pfeiffer
notifications@github.com wrote:
jbenet commentedon Aug 17, 2014
best strategies? the way docker does it?
guybrush commentedon Aug 18, 2014
im a complete go-noob, without any experience. if you want me to i can put all the deps into
github.com/jbenet/go-ipfs/vendorand also change all the import-paths. but it would be the first time i am doing this :D (for example im not sure if i should change import-paths inside vendor-dependencies?)i am currently looking into all the tools around golang, the dependency-management seems to be kind of rough (comming from nodejs&npm). there are tools to help with vendoring but none of them is ideal.
whyrusleeping commentedon Aug 18, 2014
I feel like we should have an ipfs github organization for any vendoring we do.
jbenet commentedon Aug 20, 2014
Am not too keen on premature orgs -- they add a whole bunch of hassle up front. once we have many repos, sure. (For vendoring, we don't need repos. We should be vendoring like Docker + Camlistore do -- cloning into the repo). At least until we can host the code / package manager on IPFS. :)
guybrush commentedon Aug 20, 2014
i cant wait to host all the things in ipfs, like everything hahaha
also i think vendoring like camli and docker is the best (no git-submodules)
recently i saw another tool that might not be so bad, its used in kubernetes: https://github.com/GoogleCloudPlatform/kubernetes/tree/master/Godeps
cryptix commentedon Aug 20, 2014
I'd like suggest considering Godeps, too. If all you need is locking your dependencies to specific commits/tags/versions, Godep is a very nice solution. I think docker and camlistore chose their ways because no other mature solution was available when they started.
whyrusleeping commentedon Aug 20, 2014
my issue with godeps is that its another external tool we have to be dependant on, vendoring the code is seamless and from the users perspective, no extra steps are required.
whyrusleeping commentedon Aug 20, 2014
I also want to mention that vendoring gives us the power to update our dependencies without having to push any new commits to ipfs, having 400 commits saying "Updating godeps" seems like a messy solution to me
guybrush commentedon Aug 20, 2014
the reason for vendoring is to update dependencies by commit, isnt it?
you want to be able to checkout a specific commit of ipfs and be sure to get exactly the same binary with
go buildeverytime. even when upstream repositories of dependencies change, like it happened here (the reason why i opened this issue).jbenet commentedon Aug 20, 2014
Yeah, we want it to be committed. Let's vendor the way docker + camlistore do it for now.
whyrusleeping commentedon Aug 20, 2014
Ah, I get it now.
btc commentedon Sep 7, 2014
Please see: #35
btc commentedon Sep 11, 2014
Shall we close this issue?
jbenet commentedon Sep 11, 2014
yep
Merge pull request #28 from ipfs/fix/update-README
Update screenshot in README.md (ipfs#28)