You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Version/Platform/Processor information (from ipfs version --all):
go-ipfs version: 0.4.3-dev-1c41cac
Repo version: 4
System version: amd64/linux
Golang version: devel +495e3c6 Tue May 17 04:02:11 2016 +0000
Type (bug, feature, meta, test failure, question): bug
Area (api, commands, daemon, fuse, etc): daemon
Priority (from P0: functioning, to P4: operations on fire): P2
Description:
I ran a ipfs get over night on a 13~GiB large hash, and when I woke up it hade crashed with a segmentation fault after 20%.
The ipfs get produced this output: Error: unexpected EOF
My first instinct is that the error is a 'hidden nil' where its a typed nil pointer returned through an interface. This would make it past the err != nil check on routing.go:380 and panic on line 385, but the panic trace should look different...
Proof of concept of the mentioned 'hidden nil' bug:
@karlek if you don't mind, could you update to a newer release version of go and rebuild ipfs? The possibility exists that your old version of go has a bug in it thats causing this issue (especially since its not a release build).
The crash should be solved but we added error log in place it would appear. We would love to know what is causing such an unusual behaviour, so if you could report back if the logs contain info about this bug, we would really appreciate it.
I'm a new user of ipfs, and haven't figured out how to read the output the ipfs log tail yet.
How do I supply you the logs, i.e which commands should I run to extract the relevant information?
@karlek Thanks for pinging back on this. I think that i'm going to go ahead and call it closed. Likely cause being a development version of the go compiler.
Activity
whyrusleeping commentedon Aug 3, 2016
@karlek thanks for reporting! After this happened, was the daemon still running? or did the process exit?
karlek commentedon Aug 3, 2016
The deamon didn't continue running, it crashed with the panic.
Sorry was out drinking πΊ
whyrusleeping commentedon Aug 3, 2016
No worries, this one is tricky. Thanks for the info!
whyrusleeping commentedon Aug 4, 2016
@karlek what version of go are you running? It doesnt appear to be a release version.
whyrusleeping commentedon Aug 4, 2016
My first instinct is that the error is a 'hidden nil' where its a typed nil pointer returned through an interface. This would make it past the
err != nilcheck on routing.go:380 and panic on line 385, but the panic trace should look different...Proof of concept of the mentioned 'hidden nil' bug:
Results in:
Where we can clearly see that the panic is a result of the error being nil.
dht: add in code to detect and diagnose #3032
whyrusleeping commentedon Aug 4, 2016
Pushing a PR that tries to debug and diagnose my suspicions here, It will print an error message and not crash your daemon. :)
Merge pull request #3037 from ipfs/feat/detect-issue-3032
karlek commentedon Aug 4, 2016
@whyrusleeping I use an old development version golang; haven't downloaded the latest version in a while.
whyrusleeping commentedon Aug 4, 2016
@karlek if you don't mind, could you update to a newer release version of go and rebuild ipfs? The possibility exists that your old version of go has a bug in it thats causing this issue (especially since its not a release build).
karlek commentedon Aug 4, 2016
Absolutely. Will write here if the bug reappear.
Kubuxu commentedon Aug 4, 2016
The crash should be solved but we added error log in place it would appear. We would love to know what is causing such an unusual behaviour, so if you could report back if the logs contain info about this bug, we would really appreciate it.
karlek commentedon Aug 4, 2016
I'm a new user of ipfs, and haven't figured out how to read the output the
ipfs log tailyet.How do I supply you the logs, i.e which commands should I run to extract the relevant information?
Merge branch 'ipfs/master' into develop
Kubuxu commentedon Aug 5, 2016
It will be in output of
ipfs daemon.karlek commentedon Sep 29, 2016
I haven't encountered this bug since it happened. Just to let you know!
whyrusleeping commentedon Sep 29, 2016
@karlek Thanks for pinging back on this. I think that i'm going to go ahead and call it closed. Likely cause being a development version of the go compiler.
dht: add in code to detect and diagnose ipfs#3032