Skip to content

Code bug #3063

Closed
Closed

Description

@haiheipijuan

Version/Platform/Processor information (from ipfs version --all):
go-ipfs version: 0.4.3-rc2-3ba9b67
Repo version: 4
System version: amd64/darwin
Golang version: go1.6

Type (bug, feature, meta, test failure, question):bug
Area (api, commands, daemon, fuse, etc):code
Priority (from P0: functioning, to P4: operations on fire):p1

Description:
code is here: https://github.com/ipfs/go-ipfs/blob/master/blocks/blockstore/arc_cache.go#L63, shoud be "if res {", because we don't need to to put the key into the cache does not exist.

Activity

  1. Kubuxu commented on Aug 9, 2016

    @Kubuxu
    Member

    I disagree with your statement, we want to cache both positive and negative Has responses. This means: if Has call was successful, put it into cache, no matter if it is true or false.

    The bloom filter cache is currently disabled by default so it will be unable to catch cases in which the Has response is false.

    In future we should place active bloom filter cache before ARC cache to reduce number of hits to ARC.

  2. haiheipijuan commented on Aug 10, 2016

    @haiheipijuan
    Author

    OK, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions