Skip to content

FindProviders regression #452

Closed
Closed

Description

@btc

#440 introduces a bug in the DHT that causes the following test to fail:

  1. create network with one bootstrap peer
  2. connect a server. connect a client
  3. let server add file (client waits for signal to add file)
  4. let client cat file

Test fails with output:

client: dht: �FindProviders Query error: routing: not found �routing.go:206�

The failing test is shown here: https://build.protocol-dev.com/job/ipfs-dockertest/9/console

After reverting the changes, the tests pass. The passing test is shown here: https://build.protocol-dev.com/job/ipfs-dockertest/11/console

The branch with the reverted code is here: https://github.com/jbenet/go-ipfs/tree/revert/dht

@whyrusleeping @jbenet Plan of action?

Activity

  1. added
    kind/bugA bug in existing code (including security flaws)
    on Dec 15, 2014
  2. whyrusleeping commented on Dec 15, 2014

    @whyrusleeping
    Member

    Thats odd, the new find providers only extends the previous behaviour, before it would just send the peers we had locally in our routing table, now it will do that, then search for more.

    Ill take a look at it now

  3. whyrusleeping commented on Dec 15, 2014

    @whyrusleeping
    Member

    Do you have any reproductible test case that doesnt involve docker?

  4. whyrusleeping commented on Dec 15, 2014

    @whyrusleeping
    Member

    ooooh, wait. I think i see it. We are treating an error on an individual request as an error on the whole RPC

  5. whyrusleeping commented on Dec 16, 2014

    @whyrusleeping
    Member

    @maybebtc has this been resolved? Or are you still encountering the same issue?

  6. btc commented on Dec 16, 2014

    @btc
    ContributorAuthor

    I haven't been able to reproduce the issue. Tests are passing.

  7. whyrusleeping commented on Dec 16, 2014

    @whyrusleeping
    Member

    well, if thats the case, ill close this one out.

  8. reopened this on Dec 18, 2014
  9. whyrusleeping commented on Dec 19, 2014

    @whyrusleeping
    Member

    If needed, I can shift my focus over to getting the DHT into a workable state.

  10. btc commented on Dec 23, 2014

    @btc
    ContributorAuthor

    @jbenet @whyrusleeping it's becoming increasingly likely that this is causing failures on #463

  11. jbenet commented on Dec 23, 2014

    @jbenet
    Member

    @maybebtc hm. probably :(

  12. jbenet commented on Jan 5, 2015

    @jbenet
    Member

    I think this is fixed. @briantigerchow confirm?

  13. added a commit that references this issue on Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugA bug in existing code (including security flaws)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions