You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I dont know if this has been filed already (if so, just close this one) but killing ipfs with SIGINT no longer succeeds. This should be alpha priority.
I've found it helpful to include a Debug log statement in Close() error methods of large components. Makes it easy to see when things shut down as they should.
It appears that dialAddrs in the swarm doesnt respect the context as well as it should, and even farther down, rawConnDial doesnt really use the context, but just sets a timeout. This might be part of the issue, im still investigating.
The next time anyone encounters the daemon not quitting, could you wait up to one minute? Im thinking that it might be waiting for dial calls to timeout, if thats the case, the daemon should exit once the timeout triggers and we know where to direct our debugging efforts
Activity
btc commentedon Jan 28, 2015
I've found it helpful to include a
Debuglog statement inClose() errormethods of large components. Makes it easy to see when things shut down as they should.whyrusleeping commentedon Jan 29, 2015
It appears that
dialAddrsin the swarm doesnt respect the context as well as it should, and even farther down,rawConnDialdoesnt really use the context, but just sets a timeout. This might be part of the issue, im still investigating.whyrusleeping commentedon Jan 29, 2015
looks like i noticed this before in #650
whyrusleeping commentedon Jan 29, 2015
I beleive #690 is related as well.
whyrusleeping commentedon Jan 29, 2015
More experiment notes: If i leave my daemon on for a while, and disconnect my internet connection, the daemon appears to close down properly.
jbenet commentedon Jan 29, 2015
i've observed the same. it's related to network connections. probably
contexts not cancelling properly.
On Thu, Jan 29, 2015 at 2:54 PM, Jeromy Johnson notifications@github.com
wrote:
whyrusleeping commentedon Feb 3, 2015
The next time anyone encounters the daemon not quitting, could you wait up to one minute? Im thinking that it might be waiting for dial calls to timeout, if thats the case, the daemon should exit once the timeout triggers and we know where to direct our debugging efforts
whyrusleeping commentedon Feb 3, 2015
Just confirmed that the daemon will shutdown at some point after the kill signal is sent, < 30s in my cases.
btc commentedon Feb 3, 2015
I found it useful to add log statements in the Close() methods of sub-systems to see the order in which they shutdown.
Merge pull request ipfs#682 from libp2p/fix/key-log-encoding