You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I didn't see an issue files for this, but also saw a lot of discussion recently. I just had a few comments I wanted to put down in an easier to find location than irc logs.
The idea of having the git short hash as part of the version came up but I also think that each pull request should always update the version information, in which ever regard is required (major, minor, patch).
each pull request should always update the version information
editing the same place in code would create a ton of merge conflict friction. ๐ Maybe we can write a go-semver thing that does: jbenet/random-ideas#22
then we either cant merge PRs from github-- or have to step into the codebase to change it between every PR, adding a commit. either case, every commit won't carry a version change (multi commit PRs). it's also a manual step likely to be cumbersome and missed by maintainers. I think in general the version number should be automated, or driven by an explicit publish/release step -- git tags, or package managers?
I'd also like to add that having release notes would be nice to have with each version release. It could be something as simple as listing the issues that were closed
Activity
jbenet commentedon Jan 30, 2015
editing the same place in code would create a ton of merge conflict friction. ๐ Maybe we can write a go-semver thing that does: jbenet/random-ideas#22
travisperson commentedon Jan 30, 2015
The author of the pull request doesn't do the versioning. When it's merged you update the version.
jbenet commentedon Jan 30, 2015
then we either cant merge PRs from github-- or have to step into the codebase to change it between every PR, adding a commit. either case, every commit won't carry a version change (multi commit PRs). it's also a manual step likely to be cumbersome and missed by maintainers. I think in general the version number should be automated, or driven by an explicit publish/release step -- git tags, or package managers?
dylanPowers commentedon Mar 8, 2015
I'd also like to add that having release notes would be nice to have with each version release. It could be something as simple as listing the issues that were closed
whyrusleeping commentedon Mar 8, 2015
Agreed. I'll start doing release notes when we bump versions
whyrusleeping commentedon Jan 2, 2016
this is a thing. we do version releases and changelogs