Skip to content

Add benchmark for just the time it takes to cat - #1027

Merged
jbenet merged 2 commits into
masterfrom
bench/just-cat
Apr 7, 2015
Merged

jbenet merged 2 commits into
masterfrom
bench/just-cat

Conversation

@whyrusleeping

Copy link
Copy Markdown
Member

these benchmarks ignore the time to start up nodes and add the file.

@whyrusleeping whyrusleeping added the status/in-progress In progress label Apr 6, 2015
@jbenet

jbenet commented Apr 7, 2015

Copy link
Copy Markdown
Member

πŸ‘

@jbenet

jbenet commented Apr 7, 2015

Copy link
Copy Markdown
Member

@whyrusleeping would you disable not ok 11 - ipfs get -a archive output is valid ?

@whyrusleeping

Copy link
Copy Markdown
Member Author

you want that done in this PR?

jbenet added a commit that referenced this pull request Apr 7, 2015
Add benchmark for just the time it takes to cat
@jbenet
jbenet merged commit 3056267 into master Apr 7, 2015
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Apr 7, 2015
@jbenet

jbenet commented Apr 7, 2015

Copy link
Copy Markdown
Member

thanks!

@jbenet
jbenet deleted the bench/just-cat branch April 7, 2015 04:55

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whyrusleeping shouldn't the timer be reset here to not include the work of coming up with the random data?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm looks like it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants