Repository navigation
feat: expose BlockKeyCacheSize and enable WriteThrough datastore options - #10614
Merged
Merged
Conversation
Contributor
Author
|
We can discuss a bit, because I am not sure when a non-writethrough blockstore/service makes fully sense. Probably on small datastores with very well primed caches that fit all keys and when re-writing the same keys all the time (not sure how common that is to warrant being the current default). I don't think non-WriteThrough makes sense without bloom-filter. And bloom filter is primed on boot, which triggers reading all the keys (horrible in very large datastores).
|
hsanjuan
force-pushed
the
fix/perf-pebble-improvements
branch
from
December 6, 2024 10:51
7f53a7d to
cd96506
Compare
lidel
reviewed
Dec 6, 2024
hsanjuan
force-pushed
the
fix/perf-pebble-improvements
branch
from
December 10, 2024 11:23
35cbba2 to
b4b028c
Compare
gammazero
self-requested a review
December 10, 2024 18:00
gammazero
approved these changes
Dec 11, 2024
lidel
requested changes
Dec 12, 2024
hsanjuan
force-pushed
the
fix/perf-pebble-improvements
branch
from
December 18, 2024 08:39
0703a15 to
20c81ec
Compare
Update Boxo and deps
hsanjuan
force-pushed
the
fix/perf-pebble-improvements
branch
from
December 18, 2024 08:58
3eadcc3 to
d3593a3
Compare
Contributor
Author
|
Comments have been addressed, changelog has been improved, Boxo has been updated to |
lidel
requested changes
Dec 19, 2024
using it indirectly WithDefault construct like we do for other Flags
links need to be absolute because we reuse markdown in github releases
lidel
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables WriteThrough blockstore and blockservice by default, exposing a new option and BlockKeyCacheSize to control two-queue cache and be able to disable it.