Skip to content

feat(AutoTLS): enabled by default with 1h RegistrationDelay - #10724

Merged
lidel merged 9 commits into
masterfrom
autotls-implicit-default-enable-iff
Feb 25, 2025
Merged

lidel merged 9 commits into
masterfrom
autotls-implicit-default-enable-iff

Conversation

@lidel

@lidel lidel commented Feb 19, 2025 •

Copy link
Copy Markdown
Contributor

Enables AutoTLS by default, but delays registration by 1h if user did not explicitly set AutoTLS.Enabled to true

Depends on ipshipyard/p2p-forge#58

TODO

  • feat(client): WithRegistrationDelay ipshipyard/p2p-forge#58
  • enable AutoTLS by default
  • delay implicit default AutoTLS registration by AutoTLS.RegistrationDelay=1h
  • fix tests
  • set AutoTLS.Enabled=false in test profile
  • switch to p2p-forge/client v0.4.0 release
  • update docs/config.md
    • remove EXPERIMENTAL messaging
    • de-emphasize manual configuration
  • add highlight to 0.34 changelog

Close #10560

Enables AutoTLS by default, but delays registration by 1h
if user did not explicitly set `AutoTLS.Enabled` to `true`
@lidel lidel changed the title feat(autotls): enable with RegistrationDelay feat(AutoTLS): enabled by default with RegistrationDelay Feb 20, 2025
hard fail when TCP or Websocket is not present is a bad UX + explodes
complexity of tests.

instead, we log user-friendly ERROR and disable AutoTLS when
there is no /tcp, no Websocket transport, or PNET is used with default
settings
@lidel
lidel requested review from 2color and aschmahmann February 21, 2025 01:19
@lidel lidel changed the title feat(AutoTLS): enabled by default with RegistrationDelay feat(AutoTLS): enabled by default with 1h RegistrationDelay Feb 21, 2025
@lidel
lidel marked this pull request as ready for review February 21, 2025 01:41
@lidel
lidel requested a review from a team as a code owner February 21, 2025 01:42

@lidel lidel left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lidel

lidel commented Feb 25, 2025 •

Copy link
Copy Markdown
Contributor Author

Switched to released p2p-forge/client v0.4.0 + smoke tested here and in libp2p/go-libp2p#3211.
Did not get feedback on docs, but assuming good enough – feel free to refine in separate PR.

Merging to give this a try in 0.34.0-rc1

@lidel
lidel merged commit d6a5bc0 into master Feb 25, 2025
@lidel
lidel deleted the autotls-implicit-default-enable-iff branch February 25, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enabling AutoTLS feature by default

1 participant