Skip to content

Add hamming distance calculation to bloom filters - #1085

Merged
jbenet merged 2 commits into
masterfrom
bloomfilter-hamming-distance
Apr 19, 2015
Merged

jbenet merged 2 commits into
masterfrom
bloomfilter-hamming-distance

Conversation

@krl

@krl krl commented Apr 15, 2015

Copy link
Copy Markdown
Contributor

No description provided.

@jbenet jbenet added the status/in-progress In progress label Apr 15, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code doesn't bear an actual LICENSE file. skull-squadron/hamming#3

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbenet Tyrannical, bureaucratic "standards" people exist to foist unnecessary bikeshedding FUD and work on others while contributing no real value. I refuse to set this precedent unless you have a really good reason.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not bikeshedding. I've checked this with lawyers multiple times. As things stand today, it is still required to have the full text of licenses along with the relevant code base.Β 

I already did the work for you. If you can't press one button, fine. We'll add it ourselves here. You're foisting much more work unto us -- every time we vendor -- but I don't care about arguing you on this

β€”
Sent from Mailbox

On Fri, Apr 17, 2015 at 10:11 AM, Barry Allard notifications@github.com
wrote:

@@ -0,0 +1,3 @@
+Copyright (c) 2014 Barry Allard
+
+MIT license

@jbenet Tyrannical, bureaucratic "standards" people exist to foist unnecessary bikeshedding FUD and work on others while contributing no real value. I refuse to set this precedent unless you have a really good reason.

Reply to this email directly or view it on GitHub:
https://github.com/ipfs/go-ipfs/pull/1085/files#r28611967

@jbenet

jbenet commented Apr 17, 2015

Copy link
Copy Markdown
Member

LGTM other than LICENSE concern above. @whyrusleeping ?

Comment thread blocks/bloom/filter.go

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats being xor'ed?

@whyrusleeping

Copy link
Copy Markdown
Member

this LGTM, just curious about the usecase

@jbenet

jbenet commented Apr 19, 2015

Copy link
Copy Markdown
Member

I pushed a commit with the newly vendored license. will merge when tests pass.

jbenet added a commit that referenced this pull request Apr 19, 2015
Add hamming distance calculation to bloom filters
@jbenet
jbenet merged commit c0c4fd3 into master Apr 19, 2015
@jbenet jbenet removed the status/in-progress In progress label Apr 19, 2015
@jbenet
jbenet deleted the bloomfilter-hamming-distance branch April 19, 2015 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants