Skip to content

remove unneeded thirdparty packages - #10871

Merged
gammazero merged 2 commits into
masterfrom
rm-thridparty-pkgs
Jul 16, 2025
Merged

gammazero merged 2 commits into
masterfrom
rm-thridparty-pkgs

Conversation

@gammazero

@gammazero gammazero commented Jul 16, 2025 •

Copy link
Copy Markdown
Contributor

Remove unnecessary packages from thirdparty in repo.

  • Remove thirdparty/assert (replaced by github.com/stretchr/testify/require)
  • Remove thirdparty/dir (replaced by misc/fsutil)
  • Remove thirdparty/notifier (unused)

@gammazero
gammazero requested review from a team and lidel as code owners July 16, 2025 04:03
@gammazero gammazero added the skip/changelog This change does NOT require a changelog entry label Jul 16, 2025

@guillaumemichel guillaumemichel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Remove unnecessary packages from `thirdparty` in repo.

- Remove `thirdparty/assert` (replaced by `github.com/stretchr/testify/require`)
- Remove `thirdparty/dir` (replacd by `misc/fsutil`)
- Remove `thirdparty/notifier` (unused)
@gammazero
gammazero force-pushed the rm-thridparty-pkgs branch from 2ab3a7b to 5c5950c Compare July 16, 2025 08:30
@gammazero gammazero removed the skip/changelog This change does NOT require a changelog entry label Jul 16, 2025
@gammazero
gammazero merged commit bb58ca4 into master Jul 16, 2025
@gammazero
gammazero deleted the rm-thridparty-pkgs branch July 16, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants