Repository navigation
add more bitswap task workers - #1091
Conversation
There was a problem hiding this comment.
i dont think 4 is enough?
4 * 256k = 1MB. i think the workers have to wait for the other side so a lot of time may be spent waiting for requests. this will be particularly bad in LAN settings where your 4 workers got stuck sending to 4 remote peers, but everyone else locally who you could be sending to is stuck waiting.
What's the cost of these? just a goroutine queue? if so, i'd crank it up to 16/32.
There was a problem hiding this comment.
we can also try 16/32 and see how it goes. if not good we can bring it back down.
There was a problem hiding this comment.
Maybe make this a tunable setting?
There was a problem hiding this comment.
Maybe make this a tunable setting?
π even for just being able to test. we could make this an env var first, and move it to config if we find it's very useful. (think this is a good path to avoiding cluttering the config with crap. start with env and only pull into config if needed)
There was a problem hiding this comment.
Yeah, ill make it an env var
There was a problem hiding this comment.
maybe IPFS_BITSWAP_TASK_WORKERS to scope it?
There was a problem hiding this comment.
too much typing π
There was a problem hiding this comment.
@whyrusleeping we may have other task workers. the problem with these env vars is that if we change them later we break user space. IPFS_TASK_WORKERS is way too general.
There was a problem hiding this comment.
IPFS_BITSWAP_TW
IPFS_BITSWAP_WORKERS
IPFS_BITSWAP_TASK_WORKERS
|
RFM |
|
@whyrusleeping we need to scope that var-- it's going to cause problems. want me to do it? |
|
i can do it. |
changed IPFS_TASK_WORKERS to IPFS_BITSWAP_TASK_WORKERS
No description provided.