Skip to content

don't readd entire directories recursively - #1101

Merged
jbenet merged 1 commit into
masterfrom
fix/add-perf
Apr 21, 2015
Merged

jbenet merged 1 commit into
masterfrom
fix/add-perf

Conversation

@whyrusleeping

Copy link
Copy Markdown
Member

This significantly improves the performance of adding large directories

@whyrusleeping whyrusleeping added topic/commands Topic commands topic/perf Performance labels Apr 20, 2015
@whyrusleeping whyrusleeping self-assigned this Apr 20, 2015
@whyrusleeping whyrusleeping added the status/in-progress In progress label Apr 20, 2015
@whyrusleeping

Copy link
Copy Markdown
Member Author

@jbenet i think this is RFM

Comment thread core/commands/add.go

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow. πŸ˜₯

@jbenet

jbenet commented Apr 21, 2015

Copy link
Copy Markdown
Member

LGTM. RFM

jbenet added a commit that referenced this pull request Apr 21, 2015
don't readd entire directories recursively
@jbenet
jbenet merged commit 33fab22 into master Apr 21, 2015
@jbenet jbenet removed the status/in-progress In progress label Apr 21, 2015
@jbenet
jbenet deleted the fix/add-perf branch April 21, 2015 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic/commands Topic commands topic/perf Performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants