Skip to content

telemetry: collect high level provide DHT sweep settings - #11056

Merged
lidel merged 4 commits into
masterfrom
feat/11055-telemetry-provide-system
Nov 13, 2025
Merged

lidel merged 4 commits into
masterfrom
feat/11055-telemetry-provide-system

Conversation

@hsanjuan

Copy link
Copy Markdown
Contributor

Fixes #11055.

@hsanjuan hsanjuan self-assigned this Nov 12, 2025
@hsanjuan
hsanjuan requested a review from a team as a code owner November 12, 2025 13:11
@hsanjuan

Copy link
Copy Markdown
Contributor Author

Anything else that should be collected pertaining to Provide?

@hsanjuan
hsanjuan force-pushed the feat/11055-telemetry-provide-system branch from 6bb65d7 to 5d8b661 Compare November 12, 2025 13:34
@lidel lidel assigned lidel and unassigned hsanjuan Nov 12, 2025
collects whether users customize Interval and MaxWorkers from defaults
to help identify if defaults need adjustment
@lidel lidel changed the title telemetry: collect provideDHTSweepEnabled telemetry: collect high level provide DHT sweep settings Nov 12, 2025

@lidel lidel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Added bools to track if user customized Provide.DHT.Interval and MaxWorkers.

@lidel lidel mentioned this pull request Nov 12, 2025
50 of 74 tasks
@aschmahmann

Copy link
Copy Markdown
Contributor

@lidel @hsanjuan WDYT about looking at the accelerated client use as well. Might help give more information about the landscape of how people are doing their provides and which DHT settings are working best for them.

restructure docs/telemetry.md into meaningful sections (routing & discovery,
content providing, network configuration), add exact config field paths for all
tracked settings, and establish code as source of truth by linking from LogEvent
struct while removing redundant field comments
@lidel

lidel commented Nov 13, 2025 •

Copy link
Copy Markdown
Contributor

@aschmahmann we already track this as routing_accelerated_dht_client👍

I'm merging so we have this in RC1. Pushed small changes:

  • improved docs in e12e610
  • removed from changelog fe43eed - felt like unnecessary noise

…y-provide-system

remove telemetry changelog entry as requested
@lidel lidel added the skip/changelog This change does NOT require a changelog entry label Nov 13, 2025
@lidel
lidel merged commit d45c615 into master Nov 13, 2025
@lidel
lidel deleted the feat/11055-telemetry-provide-system branch November 13, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip/changelog This change does NOT require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add telemetry data for provide system

3 participants