Skip to content

Instructions for installing command completion - #1115

Merged
whyrusleeping merged 5 commits into
ipfs:masterfrom
dylanPowers:completion-doc
Apr 22, 2015
Merged

whyrusleeping merged 5 commits into
ipfs:masterfrom
dylanPowers:completion-doc

Conversation

@dylanPowers

Copy link
Copy Markdown
Member

I have instructions for installing command completion in Linux bash. If anyone would like to add instructions for other shells and OSX. That would be great.

@dylanPowers dylanPowers added the status/in-progress In progress label Apr 21, 2015
@dylanPowers dylanPowers self-assigned this Apr 21, 2015
@whyrusleeping

Copy link
Copy Markdown
Member

This looks good to me, only comment would be maybe adding a link here: https://www.debian-administration.org/article/316/An_introduction_to_bash_completion_part_1

for "further reading"

@dylanPowers dylanPowers added codereview and removed status/in-progress In progress labels Apr 21, 2015
@dylanPowers

Copy link
Copy Markdown
Member Author

@whyrusleeping I went ahead and added in that reference

Comment thread docs/command-completion.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should tell the user what to do if they dont have go. it's possible that we could make a simple ipfs-install-bash-completion tool. i want to start making tools that we can deploy through ipfs itself, whose hashes are hardcoded in the binary.

@jbenet

jbenet commented Apr 22, 2015

Copy link
Copy Markdown
Member

@dylanPowers πŸ‘ LGTM except the last comment above o/

@dylanPowers

Copy link
Copy Markdown
Member Author

Hmm, I'm trying to think of a good place for the completion script to be stored. I suppose we could instruct them to copy it into the ~/.ipfs directory

@whyrusleeping

Copy link
Copy Markdown
Member

@dylanPowers shouldnt it go into /etc/completions?

@dylanPowers

Copy link
Copy Markdown
Member Author

@whyrusleeping This is for sourcing from ~/.bash_completion. If the user is going to put it anywhere globally, they might as put it in /etc/bash_completion.d/ and not even bother with ~/.bash_completion

@whyrusleeping

Copy link
Copy Markdown
Member

ah, gotcha. putting it in the .ipfs dir makes sense. although, i dont use bash completions, and fish does its own thing in $HOME/.config/fish

@dylanPowers

Copy link
Copy Markdown
Member Author

Can fish read bash completion scripts, or does it need it's own script?

@dylanPowers

Copy link
Copy Markdown
Member Author

I committed that last change request to remove the Go dependency from the instructions

@whyrusleeping

Copy link
Copy Markdown
Member

LGTM, RFM

whyrusleeping added a commit that referenced this pull request Apr 22, 2015
Instructions for installing command completion
@whyrusleeping
whyrusleeping merged commit b207672 into ipfs:master Apr 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants