Repository navigation
Instructions for installing command completion - #1115
Conversation
|
This looks good to me, only comment would be maybe adding a link here: https://www.debian-administration.org/article/316/An_introduction_to_bash_completion_part_1 for "further reading" |
|
@whyrusleeping I went ahead and added in that reference |
There was a problem hiding this comment.
should tell the user what to do if they dont have go. it's possible that we could make a simple ipfs-install-bash-completion tool. i want to start making tools that we can deploy through ipfs itself, whose hashes are hardcoded in the binary.
|
@dylanPowers π LGTM except the last comment above o/ |
|
Hmm, I'm trying to think of a good place for the completion script to be stored. I suppose we could instruct them to copy it into the ~/.ipfs directory |
|
@dylanPowers shouldnt it go into /etc/completions? |
|
@whyrusleeping This is for sourcing from |
|
ah, gotcha. putting it in the .ipfs dir makes sense. although, i dont use bash completions, and fish does its own thing in |
|
Can fish read bash completion scripts, or does it need it's own script? |
b3e7588 to
08c15e4
Compare
|
I committed that last change request to remove the Go dependency from the instructions |
|
LGTM, RFM |
Instructions for installing command completion
I have instructions for installing command completion in Linux bash. If anyone would like to add instructions for other shells and OSX. That would be great.